Re: [PATCH net-next v1] net: stmmac: TSO: Simplify the code flow of DMA descriptor allocations

Jakub Kicinski
2024-12-19T01:19:17Z

On Fri, 13 Dec 2024 11:00:06 +0800 Furong Xu wrote:
> - if (priv->dma_cap.addr64 <= 32)
> - desc->des0 = cpu_to_le32(curr_addr);
> - else
> - stmmac_set_desc_addr(priv, desc, curr_addr);
> -
> + stmmac_set_desc_addr(priv, desc, curr_addr);

I can't figure out if this is correct or not in a reasonable amount of
time. dwmac4 and dwxgmac2 looks pretty obviously okay. But there are
also ndesc and enh, which don't seem to map to platform in an obvious
way to an outside reviewer.

Please provide more context/guidance in the commit message, otherwise
this looks like a high risk refactoring for a driver this poorly
designed.
--
pw-bot: cr