Re: [PATCH net-next] net: phy: dp83822: Add support for PHY LEDs on DP83822

Andrew Lunn
2024-12-18T17:13:19Z

> > index is taken direct from DT. Somebody might have:
> >
> > leds {
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > led@42 {
> > reg = <42>;
> > color = <LED_COLOR_ID_WHITE>;
> > function = LED_FUNCTION_LAN;
> > default-state = "keep";
> > };
> > };
> >
> > so you should not assume if it is not 0, 1 or 2, then it must be
> > 3. Please always validate index.
> >
> dp83822_of_init_leds does a check that index is 0, 1, 2 or 3. Is this
> sufficient ? Otherwise I would validate the index.

Ah, i missed that. I'm just used to the usual pattern that every PHY
driver has a check for the MAX LEDs in their callback.

Andrew