Re: [PATCH net-next] net: phy: dp83822: Add support for PHY LEDs on DP83822

Simon Horman
2024-12-17T16:32:13Z

On Tue, Dec 17, 2024 at 10:16:03AM +0100, Dimitri Fedrau wrote:
> The DP83822 supports up to three configurable Light Emitting Diode (LED)
> pins: LED_0, LED_1 (GPIO1), COL (GPIO2) and RX_D3 (GPIO3). Several
> functions can be multiplexed onto the LEDs for different modes of
> operation. LED_0 and COL (GPIO2) use the MLED function. MLED can be routed
> to only one of these two pins at a time. Add minimal LED controller driver
> supporting the most common uses with the 'netdev' trigger.
>
> Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> ---
> drivers/net/phy/dp83822.c | 271 +++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 269 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c

...

> +static int dp83822_led_hw_control_set(struct phy_device *phydev, u8 index,
> + unsigned long rules)
> +{
> + int mode;
> +
> + mode = dp83822_led_mode(index, rules);
> + if (mode < 0)
> + return mode;
> +
> + if (index == DP83822_LED_INDEX_LED_0 || index == DP83822_LED_INDEX_COL_GPIO2)
> + return phy_modify_mmd(phydev, MDIO_MMD_VEND2,
> + MII_DP83822_MLEDCR, DP83822_MLEDCR_CFG,
> + FIELD_PREP(DP83822_MLEDCR_CFG, mode));

...

> +}
> +
> +static int dp83822_led_hw_control_get(struct phy_device *phydev, u8 index,
> + unsigned long *rules)
> +{
> + int val;
> +
> + if (index == DP83822_LED_INDEX_LED_0 || DP83822_LED_INDEX_COL_GPIO2) {

Hi Dimitri,

As per the condition near the top of dp83822_led_hw_control_set(), should
this be:

if (index == DP83822_LED_INDEX_LED_0 ||
index == DP83822_LED_INDEX_COL_GPIO2) {

Flagged by W=1 + -Wno-error build with clang-19.

drivers/net/phy/dp83822.c:1029:39: note: use '|' for a bitwise operation
1029 | if (index == DP83822_LED_INDEX_LED_0 || DP83822_LED_INDEX_COL_GPIO2) {
| ^~
|

...