Re: [PATCH net-next] net: phy: dp83822: Add support for PHY LEDs on DP83822

Dimitri Fedrau
2024-12-18T18:17:57Z

Am Wed, Dec 18, 2024 at 06:16:20PM +0100 schrieb Andrew Lunn:
> > By the way. Wouldn't it be helpful adding a u32 max_leds to
> > struct phy_driver ? Every driver supporting PHY LEDs validates index at the
> > moment. With max_leds it should be easy to check it in of_phy_leds and
> > return with an error if index is not valid.
>
> I have been considering it. However, so far developers have been good
> at adding the checks, because the first driver had the checks, cargo
> cult at its best.
>
> If we are going to add it, we should do it early, before there are too
> many PHY drivers which need updating.
>
Another solution without breaking others driver would be to add a
callback in struct phy_driver:
int (*led_validate_index)(struct phy_device *dev, int index)
It should be called in of_phy_led right after reading in reg property:
if (phydev->drv->led_validate_index)
ret = phydev->drv->led_validate_index(phydev, index);

This would solve another isssue I have. The LED pins of the DP83822 can
be multiplexed. Not all of them have per default a LED function. So I
need to set them up. In dp83822_of_init_leds I iterate over all DT nodes
in leds to get the information which of the pins should output LED
function. Using the callback would eleminate the need for copying code of
functions of_phy_leds and of_phy_led.

I can come up with a patch if you agree. I would add it to the patch
series and then we would also have a example with the DP83822.

Best regards,
Dimitri