From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87B531BBBE5 for ; Fri, 20 Dec 2024 09:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734687012; cv=none; b=o4oJs7YQhy65MsdHfMR1zucpjnH2GC0HdFURoP5YjV5MZwYnKIx03Nf79SW3HvHmoVJqJp1FarKvoZGwalzUB1T5UZciHNq4MpF0E8ZwGO1QS9gB7rXcmTxfIU0AZLQozBm1ZUjjKVotfLjgVoWpgow0P4bSiqu1Jo13X6iGgrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734687012; c=relaxed/simple; bh=Jj0obb+lLonOguOLIhPYogDbSqs834Ad0bLacTAElJM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qHTn777YEN25Q3M04Rm68m702aqGk+zBWeVL8DClFX716+fJelO73Pi5qErHkdDHjamMiY9nXervYyKJX4VmKayv0wR1380IrCaSLrH54ryX6zvdIpATKGrF6UkPT7AyjoFv79cwiETDEArJvaE4D9PESJyhZAsWWdJV6YUbRMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=dREiotVV; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dREiotVV" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MBu2no5cCDDupkBcTs3oTBK1Xoh2uY/RPBpxBEhM+7A=; b=dREiotVVEcLz1uxw34jFip+2M2 hQO8ELSKWlGWdb9pDVg0xcYsNACZCBEwO0s916uTg/Ruhnocsf9rJqywyx6dJ8JTZ0mhbKffvoc8T lY3acI6teFHVw+zCygU10jci9MwAXMXeb68p7rDFZUMYDNuZC++iFaDh6h95be06uRo4YYDFLYG8a DFycCzyo1XVS7kfbo+CSjSX5X6MIDNjes2D9ZS6QLyVQ/ekxovge61BaLZKwGnwZYp7EgnIQfGEO7 5lrMFoWfLzot5YAQXHFOBnQnMLUqQ3+zX8OhXOP9OzwiiFRdCoof40ZuNIY8MikUAuziA0ButJNfH 6GnSNmvg==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tOZKZ-00000005bo3-1m9Q; Fri, 20 Dec 2024 09:29:59 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 18A6E3003FF; Fri, 20 Dec 2024 10:29:57 +0100 (CET) Date: Fri, 20 Dec 2024 10:29:56 +0100 From: Peter Zijlstra To: ccc194101@163.com Cc: jpoimboe@kernel.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, chenchangcheng Subject: Re: [PATCH v2] objtool: add bch2_trans_unlocked_error to bcachefs noreturns. Message-ID: <20241220092956.GA17537@noisy.programming.kicks-ass.net> References: <20241220074847.3418134-1-ccc194101@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241220074847.3418134-1-ccc194101@163.com> On Fri, Dec 20, 2024 at 03:48:47PM +0800, ccc194101@163.com wrote: > From: chenchangcheng > > fix the following objtool warning during build time: > fs/bcachefs/btree_trans_commit.o: warning: objtool: bch2_trans_commit_write_locked.isra.0() falls through to next function do_bch2_trans_commit.isra.0() > fs/bcachefs/btree_trans_commit.o: warning: objtool: .text: unexpected end of section > ...... > fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function flush_new_cached_update() > fs/bcachefs/btree_update.o: warning: objtool: flush_new_cached_update() falls through to next function bch2_trans_update_by_path() > > Fixes: fd104e2967b7 ("bcachefs: bch2_trans_verify_not_unlocked()") > Signed-off-by: chenchangcheng Thanks!