* [PATCH v2] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
@ 2024-12-20 7:48 ccc194101
2024-12-20 9:29 ` Peter Zijlstra
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: ccc194101 @ 2024-12-20 7:48 UTC (permalink / raw)
To: jpoimboe
Cc: peterz, kent.overstreet, linux-kernel, chenchangcheng,
chenchangcheng
From: chenchangcheng <ccc194101@163.com>
fix the following objtool warning during build time:
fs/bcachefs/btree_trans_commit.o: warning: objtool: bch2_trans_commit_write_locked.isra.0() falls through to next function do_bch2_trans_commit.isra.0()
fs/bcachefs/btree_trans_commit.o: warning: objtool: .text: unexpected end of section
......
fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function flush_new_cached_update()
fs/bcachefs/btree_update.o: warning: objtool: flush_new_cached_update() falls through to next function bch2_trans_update_by_path()
Fixes: fd104e2967b7 ("bcachefs: bch2_trans_verify_not_unlocked()")
Signed-off-by: chenchangcheng <chenchangcheng@kylinos.cn>
---
tools/objtool/noreturns.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/noreturns.h b/tools/objtool/noreturns.h
index f37614cc2c1b..b2174894f9f7 100644
--- a/tools/objtool/noreturns.h
+++ b/tools/objtool/noreturns.h
@@ -19,6 +19,7 @@ NORETURN(__x64_sys_exit_group)
NORETURN(arch_cpu_idle_dead)
NORETURN(bch2_trans_in_restart_error)
NORETURN(bch2_trans_restart_error)
+NORETURN(bch2_trans_unlocked_error)
NORETURN(cpu_bringup_and_idle)
NORETURN(cpu_startup_entry)
NORETURN(do_exit)
base-commit: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
2024-12-20 7:48 [PATCH v2] objtool: add bch2_trans_unlocked_error to bcachefs noreturns ccc194101
@ 2024-12-20 9:29 ` Peter Zijlstra
2024-12-24 18:55 ` [tip: objtool/urgent] " tip-bot2 for chenchangcheng
2024-12-29 8:59 ` [tip: objtool/urgent] objtool: Add bch2_trans_unlocked_error() " tip-bot2 for chenchangcheng
2 siblings, 0 replies; 4+ messages in thread
From: Peter Zijlstra @ 2024-12-20 9:29 UTC (permalink / raw)
To: ccc194101; +Cc: jpoimboe, kent.overstreet, linux-kernel, chenchangcheng
On Fri, Dec 20, 2024 at 03:48:47PM +0800, ccc194101@163.com wrote:
> From: chenchangcheng <ccc194101@163.com>
>
> fix the following objtool warning during build time:
> fs/bcachefs/btree_trans_commit.o: warning: objtool: bch2_trans_commit_write_locked.isra.0() falls through to next function do_bch2_trans_commit.isra.0()
> fs/bcachefs/btree_trans_commit.o: warning: objtool: .text: unexpected end of section
> ......
> fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function flush_new_cached_update()
> fs/bcachefs/btree_update.o: warning: objtool: flush_new_cached_update() falls through to next function bch2_trans_update_by_path()
>
> Fixes: fd104e2967b7 ("bcachefs: bch2_trans_verify_not_unlocked()")
> Signed-off-by: chenchangcheng <chenchangcheng@kylinos.cn>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread* [tip: objtool/urgent] objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
2024-12-20 7:48 [PATCH v2] objtool: add bch2_trans_unlocked_error to bcachefs noreturns ccc194101
2024-12-20 9:29 ` Peter Zijlstra
@ 2024-12-24 18:55 ` tip-bot2 for chenchangcheng
2024-12-29 8:59 ` [tip: objtool/urgent] objtool: Add bch2_trans_unlocked_error() " tip-bot2 for chenchangcheng
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for chenchangcheng @ 2024-12-24 18:55 UTC (permalink / raw)
To: linux-tip-commits
Cc: chenchangcheng, Peter Zijlstra (Intel), x86, linux-kernel
The following commit has been merged into the objtool/urgent branch of tip:
Commit-ID: 0b56a9cc3fcb4eb12c9f3592a052b8aff2d4a3ee
Gitweb: https://git.kernel.org/tip/0b56a9cc3fcb4eb12c9f3592a052b8aff2d4a3ee
Author: chenchangcheng <ccc194101@163.com>
AuthorDate: Fri, 20 Dec 2024 15:48:47 +08:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Fri, 20 Dec 2024 15:31:26 +01:00
objtool: add bch2_trans_unlocked_error to bcachefs noreturns.
fix the following objtool warning during build time:
fs/bcachefs/btree_trans_commit.o: warning: objtool: bch2_trans_commit_write_locked.isra.0() falls through to next function do_bch2_trans_commit.isra.0()
fs/bcachefs/btree_trans_commit.o: warning: objtool: .text: unexpected end of section
......
fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function flush_new_cached_update()
fs/bcachefs/btree_update.o: warning: objtool: flush_new_cached_update() falls through to next function bch2_trans_update_by_path()
Fixes: fd104e2967b7 ("bcachefs: bch2_trans_verify_not_unlocked()")
Signed-off-by: chenchangcheng <chenchangcheng@kylinos.cn>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20241220074847.3418134-1-ccc194101@163.com
---
tools/objtool/noreturns.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/noreturns.h b/tools/objtool/noreturns.h
index f37614c..b217489 100644
--- a/tools/objtool/noreturns.h
+++ b/tools/objtool/noreturns.h
@@ -19,6 +19,7 @@ NORETURN(__x64_sys_exit_group)
NORETURN(arch_cpu_idle_dead)
NORETURN(bch2_trans_in_restart_error)
NORETURN(bch2_trans_restart_error)
+NORETURN(bch2_trans_unlocked_error)
NORETURN(cpu_bringup_and_idle)
NORETURN(cpu_startup_entry)
NORETURN(do_exit)
^ permalink raw reply related [flat|nested] 4+ messages in thread* [tip: objtool/urgent] objtool: Add bch2_trans_unlocked_error() to bcachefs noreturns
2024-12-20 7:48 [PATCH v2] objtool: add bch2_trans_unlocked_error to bcachefs noreturns ccc194101
2024-12-20 9:29 ` Peter Zijlstra
2024-12-24 18:55 ` [tip: objtool/urgent] " tip-bot2 for chenchangcheng
@ 2024-12-29 8:59 ` tip-bot2 for chenchangcheng
2 siblings, 0 replies; 4+ messages in thread
From: tip-bot2 for chenchangcheng @ 2024-12-29 8:59 UTC (permalink / raw)
To: linux-tip-commits
Cc: chenchangcheng, Peter Zijlstra (Intel), Ingo Molnar, x86,
linux-kernel
The following commit has been merged into the objtool/urgent branch of tip:
Commit-ID: 31ad36a271290648e7c2288a03d7b933d20254d6
Gitweb: https://git.kernel.org/tip/31ad36a271290648e7c2288a03d7b933d20254d6
Author: chenchangcheng <ccc194101@163.com>
AuthorDate: Fri, 20 Dec 2024 15:48:47 +08:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Sun, 29 Dec 2024 09:52:21 +01:00
objtool: Add bch2_trans_unlocked_error() to bcachefs noreturns
Fix the following objtool warning during build time:
fs/bcachefs/btree_trans_commit.o: warning: objtool: bch2_trans_commit_write_locked.isra.0() falls through to next function do_bch2_trans_commit.isra.0()
fs/bcachefs/btree_trans_commit.o: warning: objtool: .text: unexpected end of section
......
fs/bcachefs/btree_update.o: warning: objtool: bch2_trans_update_get_key_cache() falls through to next function flush_new_cached_update()
fs/bcachefs/btree_update.o: warning: objtool: flush_new_cached_update() falls through to next function bch2_trans_update_by_path()
bch2_trans_unlocked_error() is an Obviously Correct (tm) panic() wrapper,
add it to the list of known noreturns.
[ mingo: Improved the changelog ]
Fixes: fd104e2967b7 ("bcachefs: bch2_trans_verify_not_unlocked()")
Signed-off-by: chenchangcheng <chenchangcheng@kylinos.cn>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lkml.kernel.org/r/20241220074847.3418134-1-ccc194101@163.com
---
tools/objtool/noreturns.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/noreturns.h b/tools/objtool/noreturns.h
index f37614c..b217489 100644
--- a/tools/objtool/noreturns.h
+++ b/tools/objtool/noreturns.h
@@ -19,6 +19,7 @@ NORETURN(__x64_sys_exit_group)
NORETURN(arch_cpu_idle_dead)
NORETURN(bch2_trans_in_restart_error)
NORETURN(bch2_trans_restart_error)
+NORETURN(bch2_trans_unlocked_error)
NORETURN(cpu_bringup_and_idle)
NORETURN(cpu_startup_entry)
NORETURN(do_exit)
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-29 8:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-20 7:48 [PATCH v2] objtool: add bch2_trans_unlocked_error to bcachefs noreturns ccc194101
2024-12-20 9:29 ` Peter Zijlstra
2024-12-24 18:55 ` [tip: objtool/urgent] " tip-bot2 for chenchangcheng
2024-12-29 8:59 ` [tip: objtool/urgent] objtool: Add bch2_trans_unlocked_error() " tip-bot2 for chenchangcheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox