From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/3] staging: media: max96712: fix typo
Date: Fri, 20 Dec 2024 11:59:34 +0100 [thread overview]
Message-ID: <20241220105934.GB3634024@ragnatech.se> (raw)
In-Reply-To: <20241220104939.503547-2-laurentiu.palcu@oss.nxp.com>
Hi Laurentiu,
On 2024-12-20 12:49:36 +0200, Laurentiu Palcu wrote:
> Fix a typo in VS_LOW expression.
>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> Reviewed-by: Niklas S??derlund <niklas.soderlund+renesas@ragnatech.se>
I think your mail setup mangled my döts ;-) The Content-Type header for
this mail is set to 'text/plain; charset="us-ascii"' while the patch is
likely utf-8 encoded. Same in patch 3/3.
> ---
> drivers/staging/media/max96712/max96712.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c
> index 0751b2e048958..5228f9ec60859 100644
> --- a/drivers/staging/media/max96712/max96712.c
> +++ b/drivers/staging/media/max96712/max96712.c
> @@ -182,7 +182,7 @@ static void max96712_pattern_enable(struct max96712_priv *priv, bool enable)
> max96712_write_bulk_value(priv, 0x1052, 0, 3);
> max96712_write_bulk_value(priv, 0x1055, v_sw * h_tot, 3);
> max96712_write_bulk_value(priv, 0x1058,
> - (v_active + v_fp + + v_bp) * h_tot, 3);
> + (v_active + v_fp + v_bp) * h_tot, 3);
> max96712_write_bulk_value(priv, 0x105b, 0, 3);
> max96712_write_bulk_value(priv, 0x105e, h_sw, 2);
> max96712_write_bulk_value(priv, 0x1060, h_active + h_fp + h_bp, 2);
> --
> 2.34.1
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2024-12-20 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 10:49 [PATCH v2 0/3] staging: media: max96712: a few, mainly cosmetic, changes Laurentiu Palcu
2024-12-20 10:49 ` [PATCH v2 1/3] staging: media: max96712: fix typo Laurentiu Palcu
2024-12-20 10:59 ` Niklas Söderlund [this message]
2024-12-20 11:09 ` Laurentiu Palcu
2024-12-20 11:23 ` Laurentiu Palcu
2024-12-20 11:37 ` Niklas Söderlund
2024-12-20 10:49 ` [PATCH v2 2/3] staging: media: max96712: remove extra debug register flag Laurentiu Palcu
2024-12-20 10:55 ` Niklas Söderlund
2024-12-20 10:49 ` [PATCH v2 3/3] staging: media: max96712: add some register and field definitions Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220105934.GB3634024@ragnatech.se \
--to=niklas.soderlund@ragnatech.se \
--cc=gregkh@linuxfoundation.org \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox