* [RESEND PATCH] powerpc: Use str_on_off() helper in check_cache_coherency()
@ 2024-12-20 19:17 Thorsten Blum
2024-12-23 6:54 ` Ritesh Harjani
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-12-20 19:17 UTC (permalink / raw)
To: Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N Rao,
Madhavan Srinivasan, Hari Bathini, Thomas Gleixner, Thorsten Blum,
Thomas Weißschuh, Baoquan He, Ritesh Harjani (IBM)
Cc: linuxppc-dev, linux-kernel
Remove hard-coded strings by using the str_on_off() helper function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/powerpc/kernel/setup-common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 6fa179448c33..f7d7a93f07fc 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -834,8 +834,8 @@ static int __init check_cache_coherency(void)
if (devtree_coherency != KERNEL_COHERENCY) {
printk(KERN_ERR
"kernel coherency:%s != device tree_coherency:%s\n",
- KERNEL_COHERENCY ? "on" : "off",
- devtree_coherency ? "on" : "off");
+ str_on_off(KERNEL_COHERENCY),
+ str_on_off(devtree_coherency));
BUG();
}
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [RESEND PATCH] powerpc: Use str_on_off() helper in check_cache_coherency()
2024-12-20 19:17 [RESEND PATCH] powerpc: Use str_on_off() helper in check_cache_coherency() Thorsten Blum
@ 2024-12-23 6:54 ` Ritesh Harjani
0 siblings, 0 replies; 2+ messages in thread
From: Ritesh Harjani @ 2024-12-23 6:54 UTC (permalink / raw)
To: Thorsten Blum, Michael Ellerman, Nicholas Piggin,
Christophe Leroy, Naveen N Rao, Madhavan Srinivasan, Hari Bathini,
Thomas Gleixner, Thorsten Blum, Thomas Weißschuh, Baoquan He
Cc: linuxppc-dev, linux-kernel
Thorsten Blum <thorsten.blum@linux.dev> writes:
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/powerpc/kernel/setup-common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index 6fa179448c33..f7d7a93f07fc 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -834,8 +834,8 @@ static int __init check_cache_coherency(void)
> if (devtree_coherency != KERNEL_COHERENCY) {
> printk(KERN_ERR
> "kernel coherency:%s != device tree_coherency:%s\n",
> - KERNEL_COHERENCY ? "on" : "off",
> - devtree_coherency ? "on" : "off");
> + str_on_off(KERNEL_COHERENCY),
> + str_on_off(devtree_coherency));
> BUG();
> }
Looks good to me. Please feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
-ritesh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-23 6:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-20 19:17 [RESEND PATCH] powerpc: Use str_on_off() helper in check_cache_coherency() Thorsten Blum
2024-12-23 6:54 ` Ritesh Harjani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).