Re: [PATCH v3 2/3] drivers: base: test: Enable device model tests with KUNIT_ALL_TESTS

David Gow
2024-12-19T05:45:21Z

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

On Tue, 17 Dec 2024 at 04:12, Brian Norris <briannorris@chromium.org> wrote:
>
> Per commit bebe94b53eb7 ("drivers: base: default KUNIT_* fragments to
> KUNIT_ALL_TESTS"), it seems like we should default to KUNIT_ALL_TESTS.
>
> This enables these platform_device tests for common configurations, such
> as with:
> ./tools/testing/kunit/kunit.py run
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---

Excellent!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

>
> (no changes since v1)
>
> drivers/base/test/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
> index 5c7fac80611c..2756870615cc 100644
> --- a/drivers/base/test/Kconfig
> +++ b/drivers/base/test/Kconfig
> @@ -12,6 +12,7 @@ config TEST_ASYNC_DRIVER_PROBE
> config DM_KUNIT_TEST
> tristate "KUnit Tests for the device model" if !KUNIT_ALL_TESTS
> depends on KUNIT
> + default KUNIT_ALL_TESTS
>
> config DRIVER_PE_KUNIT_TEST
> tristate "KUnit Tests for property entry API" if !KUNIT_ALL_TESTS
> --
> 2.47.1.613.gc27f4b7a9f-goog
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5294 bytes --]