From: Kurt Borja <kuurtb@gmail.com>
To: platform-driver-x86@vger.kernel.org
Cc: ilpo.jarvinen@linux.intel.com, mario.limonciello@amd.com,
w_armin@gmx.de, hdegoede@redhat.com,
linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com,
Kurt Borja <kuurtb@gmail.com>
Subject: [PATCH 11/20] alienware-wmi: Refactor hdmi, amplifier, deepslp methods
Date: Sat, 21 Dec 2024 00:59:08 -0500 [thread overview]
Message-ID: <20241221055917.10555-12-kuurtb@gmail.com> (raw)
In-Reply-To: <20241221055917.10555-1-kuurtb@gmail.com>
Refactor show/store methods for hdmi, amplifier, deepslp sysfs groups to
use alienware_wmi_command() instead of alienware_wmax_command() which
uses deprecated WMI methods.
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
drivers/platform/x86/dell/alienware-wmi.c | 51 ++++++++++++++++-------
1 file changed, 36 insertions(+), 15 deletions(-)
diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c
index bcf3b2f80dfd..b9da5fe657a9 100644
--- a/drivers/platform/x86/dell/alienware-wmi.c
+++ b/drivers/platform/x86/dell/alienware-wmi.c
@@ -685,14 +685,18 @@ static acpi_status alienware_wmax_command(void *in_args, size_t in_size,
static ssize_t show_hdmi_cable(struct device *dev,
struct device_attribute *attr, char *buf)
{
+ struct alienfx_platdata *pdata;
acpi_status status;
u32 out_data;
struct wmax_basic_args in_args = {
.arg = 0,
};
- status =
- alienware_wmax_command(&in_args, sizeof(in_args),
- WMAX_METHOD_HDMI_CABLE, &out_data);
+
+ pdata = dev_get_platdata(dev);
+
+ status = alienware_wmi_command(pdata->wdev, WMAX_METHOD_HDMI_CABLE,
+ &in_args, sizeof(in_args), &out_data);
+
if (ACPI_SUCCESS(status)) {
if (out_data == 0)
return sysfs_emit(buf, "[unconnected] connected unknown\n");
@@ -706,14 +710,17 @@ static ssize_t show_hdmi_cable(struct device *dev,
static ssize_t show_hdmi_source(struct device *dev,
struct device_attribute *attr, char *buf)
{
+ struct alienfx_platdata *pdata;
acpi_status status;
u32 out_data;
struct wmax_basic_args in_args = {
.arg = 0,
};
- status =
- alienware_wmax_command(&in_args, sizeof(in_args),
- WMAX_METHOD_HDMI_STATUS, &out_data);
+
+ pdata = dev_get_platdata(dev);
+
+ status = alienware_wmi_command(pdata->wdev, WMAX_METHOD_HDMI_STATUS,
+ &in_args, sizeof(in_args), &out_data);
if (ACPI_SUCCESS(status)) {
if (out_data == 1)
@@ -729,8 +736,12 @@ static ssize_t toggle_hdmi_source(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
{
+ struct alienfx_platdata *pdata;
acpi_status status;
struct wmax_basic_args args;
+
+ pdata = dev_get_platdata(dev);
+
if (strcmp(buf, "gpu\n") == 0)
args.arg = 1;
else if (strcmp(buf, "input\n") == 0)
@@ -739,8 +750,8 @@ static ssize_t toggle_hdmi_source(struct device *dev,
args.arg = 3;
pr_debug("alienware-wmi: setting hdmi to %d : %s", args.arg, buf);
- status = alienware_wmax_command(&args, sizeof(args),
- WMAX_METHOD_HDMI_SOURCE, NULL);
+ status = alienware_wmi_command(pdata->wdev, WMAX_METHOD_HDMI_SOURCE,
+ &args, sizeof(args), NULL);
if (ACPI_FAILURE(status))
pr_err("alienware-wmi: HDMI toggle failed: results: %u\n",
@@ -778,14 +789,17 @@ static const struct attribute_group hdmi_attribute_group = {
static ssize_t show_amplifier_status(struct device *dev,
struct device_attribute *attr, char *buf)
{
+ struct alienfx_platdata *pdata;
acpi_status status;
u32 out_data;
struct wmax_basic_args in_args = {
.arg = 0,
};
- status =
- alienware_wmax_command(&in_args, sizeof(in_args),
- WMAX_METHOD_AMPLIFIER_CABLE, &out_data);
+
+ pdata = dev_get_platdata(dev);
+
+ status = alienware_wmi_command(pdata->wdev, WMAX_METHOD_AMPLIFIER_CABLE,
+ &in_args, sizeof(in_args), &out_data);
if (ACPI_SUCCESS(status)) {
if (out_data == 0)
return sysfs_emit(buf, "[unconnected] connected unknown\n");
@@ -822,13 +836,17 @@ static const struct attribute_group amplifier_attribute_group = {
static ssize_t show_deepsleep_status(struct device *dev,
struct device_attribute *attr, char *buf)
{
+ struct alienfx_platdata *pdata;
acpi_status status;
u32 out_data;
struct wmax_basic_args in_args = {
.arg = 0,
};
- status = alienware_wmax_command(&in_args, sizeof(in_args),
- WMAX_METHOD_DEEP_SLEEP_STATUS, &out_data);
+
+ pdata = dev_get_platdata(dev);
+
+ status = alienware_wmi_command(pdata->wdev, WMAX_METHOD_DEEP_SLEEP_STATUS,
+ &in_args, sizeof(in_args), &out_data);
if (ACPI_SUCCESS(status)) {
if (out_data == 0)
return sysfs_emit(buf, "[disabled] s5 s5_s4\n");
@@ -845,9 +863,12 @@ static ssize_t toggle_deepsleep(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
{
+ struct alienfx_platdata *pdata;
acpi_status status;
struct wmax_basic_args args;
+ pdata = dev_get_platdata(dev);
+
if (strcmp(buf, "disabled\n") == 0)
args.arg = 0;
else if (strcmp(buf, "s5\n") == 0)
@@ -856,8 +877,8 @@ static ssize_t toggle_deepsleep(struct device *dev,
args.arg = 2;
pr_debug("alienware-wmi: setting deep sleep to %d : %s", args.arg, buf);
- status = alienware_wmax_command(&args, sizeof(args),
- WMAX_METHOD_DEEP_SLEEP_CONTROL, NULL);
+ status = alienware_wmi_command(pdata->wdev, WMAX_METHOD_DEEP_SLEEP_CONTROL,
+ &args, sizeof(args), NULL);
if (ACPI_FAILURE(status))
pr_err("alienware-wmi: deep sleep control failed: results: %u\n",
--
2.47.1
next prev parent reply other threads:[~2024-12-21 6:00 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 5:58 [PATCH 00/20] alienware-wmi driver rework Kurt Borja
2024-12-21 5:58 ` [PATCH 01/20] alienware-wmi: Remove unnecessary check at module exit Kurt Borja
2024-12-27 0:32 ` Armin Wolf
2024-12-21 5:58 ` [PATCH 02/20] alienware-wmi: Move Lighting Control State Kurt Borja
2024-12-27 0:35 ` Armin Wolf
2024-12-27 4:32 ` Kurt Borja
2024-12-21 5:59 ` [PATCH 03/20] alienware-wmi: Modify parse_rgb() signature Kurt Borja
2024-12-27 0:36 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 04/20] alienware-wmi: Improve hdmi_mux, amplifier and deepslp group creation Kurt Borja
2024-12-27 0:44 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 05/20] alienware-wmi: Improve rgb-zones " Kurt Borja
2024-12-27 1:04 ` Armin Wolf
2024-12-27 4:37 ` Kurt Borja
2024-12-29 0:17 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 06/20] alienware_wmi: Clean variable declaration in thermal methods Kurt Borja
2024-12-27 1:06 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 07/20] alienware-wmi: Add a state container for LED control feature Kurt Borja
2024-12-27 1:32 ` Armin Wolf
2024-12-27 4:39 ` Kurt Borja
2024-12-21 5:59 ` [PATCH 08/20] alienware-wmi: Add WMI Drivers Kurt Borja
2024-12-27 3:21 ` Armin Wolf
2024-12-27 4:44 ` Kurt Borja
2024-12-27 4:48 ` Kurt Borja
2024-12-29 0:26 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 09/20] alienware-wmi: Add a state container for thermal control methods Kurt Borja
2024-12-27 3:26 ` Armin Wolf
2024-12-27 4:50 ` Kurt Borja
2024-12-21 5:59 ` [PATCH 10/20] alienware-wmi: Refactor LED " Kurt Borja
2024-12-27 3:41 ` Armin Wolf
2024-12-27 4:52 ` Kurt Borja
2024-12-21 5:59 ` Kurt Borja [this message]
2024-12-27 3:43 ` [PATCH 11/20] alienware-wmi: Refactor hdmi, amplifier, deepslp methods Armin Wolf
2024-12-21 5:59 ` [PATCH 12/20] alienware-wmi: Refactor thermal control methods Kurt Borja
2024-12-27 3:45 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 13/20] alienware-wmi: Split DMI table Kurt Borja
2024-12-27 3:55 ` Armin Wolf
2024-12-27 4:55 ` Kurt Borja
2024-12-29 0:30 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 14/20] MAINTAINERS: Update ALIENWARE WMI DRIVER entry Kurt Borja
2024-12-27 3:56 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 15/20] platform/x86: Rename alienware-wmi.c Kurt Borja
2024-12-27 3:57 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 16/20] platform/x86: Add alienware-wmi.h Kurt Borja
2024-12-27 4:02 ` Armin Wolf
2024-12-27 4:56 ` Kurt Borja
2024-12-21 5:59 ` [PATCH 17/20] platform-x86: Split the alienware-wmi driver Kurt Borja
2024-12-27 4:04 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 18/20] platform/x86: dell: Modify Makefile alignment Kurt Borja
2024-12-27 4:05 ` Armin Wolf
2024-12-27 4:57 ` Kurt Borja
2024-12-29 0:31 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 19/20] platform/x86: Update alienware-wmi config entries Kurt Borja
2024-12-27 4:08 ` Armin Wolf
2024-12-27 4:59 ` Kurt Borja
2024-12-29 0:32 ` Armin Wolf
2024-12-21 5:59 ` [PATCH 20/20] alienware-wmi: Update header and module information Kurt Borja
2024-12-27 4:08 ` Armin Wolf
2024-12-27 5:01 ` Kurt Borja
2024-12-22 23:06 ` [PATCH 00/20] alienware-wmi driver rework Armin Wolf
2024-12-25 20:25 ` Armin Wolf
2024-12-25 20:36 ` Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241221055917.10555-12-kuurtb@gmail.com \
--to=kuurtb@gmail.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=w_armin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).