From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3006233D1 for ; Sun, 22 Dec 2024 11:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734865521; cv=none; b=P8lBmSEx35GObqwv1kwzKnVV796qTb/Mj6MndiZvyUOy6l5M+l5km/I67BmBp55ofKeJO9TiCnCj4jYtLeVCaBUKd9i+sqyGz4AYCa8HW1r61dn6OaahFH6V4bxAhNrDG3C3soUePwtougPgZw1ddhHVmiVMvVjJKGREYJhc8Q4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734865521; c=relaxed/simple; bh=mtU7UEf5z3W2UdMMQiSNWpTqAO+AeJv+zY4spwpg/Ps=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kTrFJ3YOtvJ5zwnpQWhnbuyWTsxIQRlpH61Dm8ZGIdslrK2LkdCT+j9r9rXYgENx3RZPl7I25w2kSAQBTqSLO9Umb6EdwbC9FfxJ8BZOuc+iHkplgTVd+TwQR7kaZed+rkAS9akikvlV7QJ7a0LxY6KXwmsBsdi9boY/qgnuJK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Lk7edSDf; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Lk7edSDf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eni0/ysmBB+qw8lIcnGoUEAL1EApDb5uzssyZrxxW3Q=; b=Lk7edSDfRwBodk0KNiycYr/Oaa sQxcnr/tfmy6DRJB3/apbxLnMZXloWKKN2/seMnjVj+7AsWAqkwEYyKedAKJDpGXhHyvLtYqMLNSr vTMGS+N3mriC98zOFxSZTZlZTRQw4ErtoCF0OEcLWTorO5gKkSKfGFqTfN/zFKTi/ca6qRIBRWJIR 5oE2ZfNVVVbEKx/Jt0sE09Q1NUGLEAxceCp6UcF1s19Qh5G3x5S4VQtIgOsixW7iC7dCcp4VNRRN4 1iJOcqg+Ddwfynt0KR4/43W1KRSkhMtkIFUpF7YUoFD5zNQkK1V3t21vNHgrnEgpBN4tksdnYaisC 4vOYq7Qg==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tPJll-000000066dz-36at; Sun, 22 Dec 2024 11:05:10 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5211B3003AF; Sun, 22 Dec 2024 12:05:09 +0100 (CET) Date: Sun, 22 Dec 2024 12:05:09 +0100 From: Peter Zijlstra To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org Subject: Re: [PATCH 03/10] x86,mm: add INVLPGB support code Message-ID: <20241222110509.GS11133@noisy.programming.kicks-ass.net> References: <20241222040717.3096835-1-riel@surriel.com> <20241222040717.3096835-4-riel@surriel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241222040717.3096835-4-riel@surriel.com> On Sat, Dec 21, 2024 at 11:06:35PM -0500, Rik van Riel wrote: > +static inline void __invlpgb(unsigned long asid, unsigned long pcid, unsigned long addr, > + int extra_count, bool pmd_stride, unsigned long flags) > +{ > + u64 rax = addr | flags; > + u32 ecx = (pmd_stride << 31) | extra_count; > + u32 edx = (pcid << 16) | asid; > + > + /* > + * The memory clobber is because the whole point is to invalidate > + * stale TLB entries and, especially if we're flushing global > + * mappings, we don't want the compiler to reorder any subsequent > + * memory accesses before the TLB flush. > + */ > + asm volatile("invlpgb" : : "a" (rax), "c" (ecx), "d" (edx)); What memory clobber? Is "memory" gone missing? > +}