Re: [PATCH 08/11] VFS: add inode_dir_lock/unlock

Hillf Danton
2024-12-24T10:26:56Z

On Tue, 24 Dec 2024 07:36:08 +1100 NeilBrown <neilb@suse.de>
> On Mon, 23 Dec 2024, Hillf Danton wrote:
> > On Mon, 23 Dec 2024 14:10:07 +1100 NeilBrown <neilb@suse.de>
> > > On Sat, 21 Dec 2024, Hillf Danton wrote:
> > > > Inventing anything like mutex sounds bad.
> > >
> > > In general I would agree. But when the cost of adding a mutex exceeds
> > > the cost of using an alternate solution that only requires 2 bits, I
> > > think the alternate solution is justified.
> > >
> > Inode deserves more than the 2 bits before such a solution is able to
> > rework mutex.
>
> I'm sorry but I don't understand what you are saying. Could you please
> give more details about your concern?
> Are you concerned about correctness? Performance? Maintainability?
> Something else?
>
It is that you are adding a pair of honey bee wings to A380, so no takeoff
can be expected.