From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 051B854648 for ; Thu, 26 Dec 2024 19:49:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242549; cv=none; b=OCj7r/MOH85Pr9fj2hRb20Us8lpQx6fjSeIroml9jYbk8J8czXF8yZPcg44Ll/qsHlC2pLPG+vKeLsI/77Yte9ab++1irpQSLhEitTvkxKUeLX4sQO5Psfzb/pm46xwmrQ93DpG7mygl+nFJRMyCNdql6UC5UOTq00Raj+YfOqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735242549; c=relaxed/simple; bh=osJG9U2LQpiESdIt0DhLcfy7YYH6SOXFc5r2mJR+wwg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=LPu4R20/ytWO9/4GUoL9z8swuG3VddkPr3kucxHHpwO4l6i2JvvSoZGOyf1y+HAPZhH8qbpfbIR9mnBc+IpaEqZol10+Knr6q/NeZ+5nMI31ycyEnhjlPSZdJFX0NNcXN8WUlVBQFRZ1VbYDClqJO+gtMr08RUA4kTgnTstoJ3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dw0QhFRb; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dw0QhFRb" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2ef7733a1dcso1302847a91.3 for ; Thu, 26 Dec 2024 11:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735242546; x=1735847346; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9AjawiFN0l2lNjZO5eJu0bWfeIcoDpaJaDJT1q6R/Qs=; b=Dw0QhFRb+h27n8T6XR1rWf2to7xJbRc+coWkdC2lc3LD+LGRahDIANaQE1vu5Uk+ez gj9o+mJnfXqRNfF+LNv3sg3dzecrrnvkPrQ2T+MqVCjj86h4L7b63Gi1fCpn3BdHJhqi KHSavDVMoahvrBeVTImazXRxiWvQVbuzZiTp6hVfV9vFbfXCrp3e8Orqw31L+bjPPEmy vyy4GtA4ahndo1bsHD219SiJ+dCNe9I/yEuMkvTkYlBRGOJ9yZGZkBjWkRf1M8f7MsFd cvbcxXmqbU2WMKrUE5cRUBpYNq6rjs5GJYLYYkCc3N4tILK0uKCWFgGVY7KDLmqHBEi7 6r5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735242546; x=1735847346; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9AjawiFN0l2lNjZO5eJu0bWfeIcoDpaJaDJT1q6R/Qs=; b=f/IxscODqDoCyLCWwx7dIdmhfgYWi4OcADcc93V+YvMgMNeev13i8uuIEQhoWJAk8w IJscxr4RSUWlS33PzCcHPFWrpQMK07PYCR5sjO0Hv6d/t4V4XtOsJHFBq7gxBRoP9wLf k5xNdjv+Lj4NCleyu6H+3K7yNdbKtwTmQEc0Iih3fWbShj0F5kBfVMg1tep8ArJhdPRH hFKzJofiBr+ulY0Smhw/OhXYI4Fx03x10+Iu02kteocRukjkNyK6KH0MxYwpJ4Gu8nP5 EWi1QRzIvUpok54+bfN0fjILXe5Ir8Q9iYwj1cns3ozRJGD1j+gPhRgipCf6kbM09rfG fPCw== X-Forwarded-Encrypted: i=1; AJvYcCX7ZHbbCaXWZBdQux+UixZ6W2XEeJzXNKM7Ju6AYDJbeeBlNvXwE4a57YIhR5GEO7TGeeXsK6bXnV47jLI=@vger.kernel.org X-Gm-Message-State: AOJu0YzAM+O6aQBPSjPDwelOzqeZQfDXGE3bk/3mXGYvlV5cZrZ1EcY8 H7yoPoOaEg8B4WhnN5bsEwmb7C7xIrxR0cyg15RI6q/UGOQNPyzD X-Gm-Gg: ASbGncveY4yRXuhxR6oPANv2le1cKA1KVJdXn21HerBrTElpjr6DibytSte503xwaMu JBePbD2rD5A20fj5++cKMj1hmHohyshV8wg3kLy9XLiBYOxiHgQ+mtVCGZm2avJP1WP5tWVKl89 BXYB7OoW15zNvxLzrlc7e5HWdWNbEbQ10pIfyLMLL1lHk8oGD8Ttt26ORxiwn7AW8PMhubAlYYl fzL9f5jyh3/Ox1zm5D0uvqNZ5BZ0HQ8VhZBHp/5oZfiP8qQ0VlMx7o= X-Google-Smtp-Source: AGHT+IEyGVlo+v8M2T4yajYtuwJKSJsqDkxQg5dD0OadC7+8c8QjHGBP3iAleAFGyxcZdwILt8RQTw== X-Received: by 2002:a05:6a00:ad2:b0:725:d9b6:3938 with SMTP id d2e1a72fcca58-72abdf0ec05mr13413058b3a.3.1735242546182; Thu, 26 Dec 2024 11:49:06 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842e35d4becsm10304580a12.79.2024.12.26.11.49.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2024 11:49:05 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v4 00/15] staging: gpib: Handle gpib_register_driver() errors Date: Fri, 27 Dec 2024 01:06:24 +0530 Message-Id: <20241226193637.241049-1-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit While reviewing the patch for fixing Coverity scan issue from gpib: cb7210 [1], Greg pointed out that the gpib_register_driver() function can fail and must return an error value if it fails. This patch series fixes the above issue by changing the return type of gpib_register_driver() function and returning the error value if it fails. This fix also makes sure that wherever the gpib_register_driver() is called and if it fails - the previous driver register functions are unregistered(if they exist) and the error value is returned. Thanks, Nihar v3 --> v4 : Made the v3 patch into series and also fixed an error in v3 [2]. Each patch in this series is a fix for particular driver handling the gpib_register_driver() error. v2 --> v3 : Modified the gpib_register_driver() to return error code, added error handling to all the places that the gpib_register_driver() is called. v1 --> v2 : Replaced the redundant cb_pcmcia_init_module() with pcmcia_register_driver(). Link to v3 : https://lore.kernel.org/all/20241221214822.163667-1-niharchaithanya@gmail.com/ Link to v1 : https://lore.kernel.org/all/20241221022632.20931-1-niharchaithanya@gmail.com/ Link to v2 : https://lore.kernel.org/all/20241221091121.35476-1-niharchaithanya@gmail.com/ [1] https://lore.kernel.org/all/2024122133-outskirts-causing-099a@gregkh/ [2] https://lore.kernel.org/all/202412221424.WIjKFIPf-lkp@intel.com/ Nihar Chaithanya (15): staging: gpib: Modify gpib_register_driver() to return error if it fails staging: gpib: agilent_82350b: Handle gpib_register_driver() errors staging: gpib: agilent_82357a: Handle gpib_register_driver() errors staging: gpib: cb7210: Handle gpib_register_driver() errors staging: gpib: cec: Handle gpib_register_driver() errors staging: gpib: fluke: Handle gpib_register_driver() errors staging: gpib: fmh: Handle gpib_register_driver() errors staging: gpib: gpio: Return error value from gpib_register_driver() staging: gpib: hp_82335: Return error value from gpib_register_driver() staging: gpib: hp82341: Handle gpib_register_driver() errors staging: gpib: ines: Handle gpib_register_driver() errors staging: gpib: lpvo_usb: Return error value from gpib_register_driver() staging: gpib: ni_usb: Handle gpib_register_driver() errors staging: gpib: pc2: Handle gpib_register_driver() errors staging: gpib: tnt4882: Handle gpib_register_driver() errors .../gpib/agilent_82350b/agilent_82350b.c | 21 +++- .../gpib/agilent_82357a/agilent_82357a.c | 13 ++- drivers/staging/gpib/cb7210/cb7210.c | 96 +++++++++++++------ drivers/staging/gpib/cec/cec_gpib.c | 12 +-- drivers/staging/gpib/common/gpib_os.c | 7 +- drivers/staging/gpib/eastwood/fluke_gpib.c | 28 ++++-- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 43 ++++++--- drivers/staging/gpib/gpio/gpib_bitbang.c | 5 +- drivers/staging/gpib/hp_82335/hp82335.c | 6 +- drivers/staging/gpib/hp_82341/hp_82341.c | 14 ++- drivers/staging/gpib/include/gpibP.h | 2 +- drivers/staging/gpib/ines/ines_gpib.c | 78 ++++++++++----- .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 4 +- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 13 ++- drivers/staging/gpib/pc2/pc2_gpib.c | 30 +++++- drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 87 +++++++++++++---- 16 files changed, 344 insertions(+), 115 deletions(-) -- 2.34.1