Re: [PATCH v5 05/10] dt-bindings: media: Add amlogic,c3-isp.yaml

Krzysztof Kozlowski
2025-01-23T07:23:22Z

On 22/01/2025 14:38, Jacopo Mondi wrote:
> On Fri, Dec 27, 2024 at 08:22:22AM +0100, Krzysztof Kozlowski wrote:
>> On 27/12/2024 08:09, Keke Li via B4 Relay wrote:
>>> +
>>> + clocks:
>>> + maxItems: 2
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: vapb
>>> + - const: isp0
>>> +
>>> + assigned-clocks: true
>>> +
>>> + assigned-clock-rates: true
>>
>> No, drop these. Request re-review if you add new properties.
>
> Why ?
>
> I think the patches should be re-checked and it's fair to ask to drop
> the rb tag.

So I asked.

> But the idea that patches once reviewed should not be
> modified between two different versions of the same set seems really..
> debatable ?
No one said that. If you want to modify, no problem, but drop the tag.
You cannot sneak new properties while keeping the review tag.

Best regards,
Krzysztof