From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80FE31798F for ; Sat, 28 Dec 2024 06:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735367138; cv=none; b=s1RqZ56CK1PxEBciA879+1vIFz9zgQ8UCjhj2MBTznY1LIBxUa8LrPayYCH9fhPO1mVYtYC1V+br2zEFZqdLr+qMMrS6tM50OchtMSShwVbYgpfhdesXfWGxAjOGAr6NUVVYNzqoPp6V8w9gEKekjGWC3GeD63PHoFMsh21Efxk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735367138; c=relaxed/simple; bh=1jPo2JHin0LgQlm4vKXeGh2HLIjD+OuBskgQrOYzzKg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=eGQpbmcNv0cSMlBTSVUXM3Vekj2CGJ7p0ivCZJ/gC/aq6z4UnQg4hDPAkXsJKUlwI5JHz2RT6QJ77y1MaQXtuP2GmX0nwtncU2z3p724ZBGX82Un4frczfS5d2v1R8D+ojrElZdMESyZWkZn08AllLFQGN3RpfRBlAJI7cF0T18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a9wfR2a+; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a9wfR2a+" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-21a0374a1fcso6939165ad.2 for ; Fri, 27 Dec 2024 22:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735367136; x=1735971936; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UKZvoMOFa+RbGKxA6Ich2DTnwsMQAd7ewYLEegwqBEo=; b=a9wfR2a+QEF/cXFQeXAQ50RQRQ3gOKzRd/bS5up4ZaaVHtc10oswPVNn1Eb1FOvKiB lQLao7L5ZsgnO+9vfHp3T/M5cQz9QtGANykMCU8LLWte8hq46qKQfflIX+MKypO6IAbL J2th9AfMPcQuHsfmUu4EqPC7eynRrCG2iZDEwdnu8GrdmlWqGKlOoObkniLeoaYz+xpy 8ZntwUkqBd0v7pyTStowt49qXxzqCKRg1vO3cOWibdQJvMrj+rEFrHBI+p8HzLvIoZOD D0y3NW1E5drAzLPvGcv0yds64YZ3gEFMy91gGJDRHAeeBazZ4ZIgwn+xoQmCiLDg5obA W3kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735367136; x=1735971936; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UKZvoMOFa+RbGKxA6Ich2DTnwsMQAd7ewYLEegwqBEo=; b=NGzfESnICJWR115N06qgJlUOQaPdVZBdDx9w3LNKLaTspjQ+z7+beb1Mu6YY2bnUgV CNtWQMZ/KOSxv4ECRwWQKH9ClXvXzblePcACJ2B4TswjUGfoyEhQALOps1ips8uhYXJ0 74cm6H6S/co58WR1Y6EsYYYp+lOVfsyUp0hj1v6uDwblvBmi/mrPifyCKOr825Q/ml3Z IWdcfImWFBJMrSPJ+FvKL7TFVJQoMjUWBtZ+HLKm5/BUiH0dosopdP14g5J95wBFPBEX uQ/oCGEZYJnJKM12zkxsTCXu0GksDeJ8OAl1DDguKuY04o/a3gHI02zTLBqo4mpMzL8n UCFA== X-Forwarded-Encrypted: i=1; AJvYcCWvmk6GluRV+cyFLVd/Zn6RlW0HP5UfKIOp6xCRc4G1b8J+CY3BdyoNDdm/FBN7IK2Cdb+3syCEgVK7WeY=@vger.kernel.org X-Gm-Message-State: AOJu0YyMfoDmdia5XRM6UpmhRuC2gy2myOIjY3U5s001RfousQsWxPQM QJ5BiHKUyuc33bww8prqnze9BVJjz2w59SuJCBZCmkgsSZXcfZaM X-Gm-Gg: ASbGncupTkZJLBKLLNbfYkwiT+iDdjGu7LhGGqIRgV47cxD1Nl7g01CSYCaeAqAOrGc 2ceTmWogjBvL1EQgOnfG3304vpzU3r5moDIXeZ4dDANLMBhjCNSrgAjCvIUvnXiQ1jtgmRJefwF mvatlCgPzO0N6O2xb7iX+kTPCVvcKB9BfU2+k/gmIdT3TE/zteJHggpMfg8lLAdsBjlsJ+6gXLX PPMwCGOtvSRaufkVJ1XLDu6HBxcs6AOUDZ3ooyNulkzq9uUaRCq/Uo= X-Google-Smtp-Source: AGHT+IGp39FpeVG+VRoBYgltwm8XnLEWje5eSAJA15xfCgvGeZts7RNRP7020sA9OtAUWqX4Lj+MCQ== X-Received: by 2002:a17:903:2a8c:b0:215:9a73:6c4f with SMTP id d9443c01a7336-219e6e9de89mr155298355ad.6.1735367135690; Fri, 27 Dec 2024 22:25:35 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f73f6sm144479455ad.222.2024.12.27.22.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 22:25:35 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v5 00/15] staging: gpib: Handle gpib_register_driver() errors Date: Sat, 28 Dec 2024 11:37:48 +0530 Message-Id: <20241228060800.107653-1-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit While reviewing the patch for fixing Coverity scan issue from gpib: cb7210 [1], Greg pointed out that the gpib_register_driver() function can fail and must return an error value if it fails. This patch series fixes the above issue by changing the return type of gpib_register_driver() function and returning the error value if it fails. This fix also makes sure that wherever the gpib_register_driver() is called and if it fails - the previous driver register functions are unregistered(if they exist) and the error value is returned. Thanks, Nihar v4 --> v5 : Added pr_* statements indicating when the driver register functions fail or if the module is initialized without errors. v3 --> v4 : Made the v3 patch into series and also fixed an error in v3 [2]. Each patch in this series is a fix for particular driver handling the gpib_register_driver() error. v2 --> v3 : Modified the gpib_register_driver() to return error code, added error handling to all the places that the gpib_register_driver() is called. v1 --> v2 : Replaced the redundant cb_pcmcia_init_module() with pcmcia_register_driver(). Link to v4 : https://lore.kernel.org/all/20241226193637.241049-16-niharchaithanya@gmail.com/ Link to v3 : https://lore.kernel.org/all/20241221214822.163667-1-niharchaithanya@gmail.com/ Link to v2 : https://lore.kernel.org/all/20241221091121.35476-1-niharchaithanya@gmail.com/ Link to v1 : https://lore.kernel.org/all/20241221022632.20931-1-niharchaithanya@gmail.com/ [1] https://lore.kernel.org/all/2024122133-outskirts-causing-099a@gregkh/ [2] https://lore.kernel.org/all/202412221424.WIjKFIPf-lkp@intel.com/ Nihar Chaithanya (15): staging: gpib: Modify gpib_register_driver() to return error if it fails staging: gpib: agilent_82350b: Handle gpib_register_driver() errors staging: gpib: agilent_82357a: Handle gpib_register_driver() errors staging: gpib: cb7210: Handle gpib_register_driver() errors staging: gpib: cec: Handle gpib_register_driver() errors staging: gpib: fluke: Handle gpib_register_driver() errors staging: gpib: fmh: Handle gpib_register_driver() errors staging: gpib: gpio: Return error value from gpib_register_driver() staging: gpib: hp_82335: Return error value from gpib_register_driver() staging: gpib: hp_82341: Handle gpib_register_driver() errors staging: gpib: ines: Handle gpib_register_driver() errors staging: gpib: lpvo_usb: Return error value from gpib_register_driver() staging: gpib: ni_usb: Handle gpib_register_driver() errors staging: gpib: pc2: Handle gpib_register_driver() errors staging: gpib: tnt4882: Handle gpib_register_driver() errors .../gpib/agilent_82350b/agilent_82350b.c | 21 +++- .../gpib/agilent_82357a/agilent_82357a.c | 18 +++- drivers/staging/gpib/cb7210/cb7210.c | 99 ++++++++++++++----- drivers/staging/gpib/cec/cec_gpib.c | 9 +- drivers/staging/gpib/common/gpib_os.c | 7 +- drivers/staging/gpib/eastwood/fluke_gpib.c | 28 +++++- drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 41 ++++++-- drivers/staging/gpib/gpio/gpib_bitbang.c | 7 +- drivers/staging/gpib/hp_82335/hp82335.c | 9 +- drivers/staging/gpib/hp_82341/hp_82341.c | 18 +++- drivers/staging/gpib/include/gpibP.h | 2 +- drivers/staging/gpib/ines/ines_gpib.c | 81 +++++++++++---- .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 6 +- drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 17 +++- drivers/staging/gpib/pc2/pc2_gpib.c | 34 ++++++- drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 87 +++++++++++++--- 16 files changed, 387 insertions(+), 97 deletions(-) -- 2.34.1