From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E6F27405A for ; Sat, 28 Dec 2024 06:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735367167; cv=none; b=Rxh2mnN5RQDm7k5Oj4wvlg3RF+ZHhVSScDUSj5OWNAZd0OWHWUMo3q4FfxbKoTqg4y+nF2CpJw81UkDVlEP4iel0VJb3zqq0F6S9VBKt65g96FvsiC+qwf6bW2DgPr0lc1kdrSptJFet2L3qT2taR3XHXnQqPxBShhbW+ZBYQLk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735367167; c=relaxed/simple; bh=Xkj3OhYt0HsoR7LS8r60bpO4lP0pmIMbSAM1dLoqnkI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kwNJ0rBmXWCR82ZKt+SMmsoS0be145dsC2MjN1SE8zINpdy3QTqkRBWS9WrTED/bDMlMV7FOAeQsBZos8nIQTJeNWKsERxr3jclKftRoan2vXEC6JZ3kuVJowF8HY/vonDXH2K69QbyA2j/qQiVHUK29fFTUfwGk16FEW6Gbi3Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=naWD/K2V; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="naWD/K2V" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2162699e0ccso11252975ad.0 for ; Fri, 27 Dec 2024 22:26:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735367165; x=1735971965; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bu+fa23bR/zX4SKFUNVb2wSGAsaVSctXfIzv3zCZzfM=; b=naWD/K2VcND9oVJijIL4+WQklDWTHbZxN8b3CCVJr3+8SgTP/zrEw1fJDp0UBEpinG WGnpKhzDCwJGOYE8l0B2umW/0gO36oRdpkigcDcPEckMTlWbtcRxLerRFOUgUazUAlrt VzAVKPR0fQiUOHREOMmmIwW360QYrppGeP753rg5mwD7CnJkXtivapSusv9BX1NyTWG2 CBlt1PiJeRLNzj+fWZz0OpOCpqNmQlsRucrcZb8PHfMxGxzmwaaUR3UGs7NsiQCdTdDI lUORzi6iXgMZp+32BMxkyVBuIIB6b6lib1jHftfFv/1kS2YVVcCpCJ87BJ/hU193Lygr b/Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735367165; x=1735971965; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bu+fa23bR/zX4SKFUNVb2wSGAsaVSctXfIzv3zCZzfM=; b=iRM42/DKr7FW0CQdt54vNOD6JyrYJx8gopg4fC0ZRUnLLo9VSWBIq2VX0ozHGXb0hs iseonxL2/hT4VaoPkhNtH4lYiDmLFl5OYPE88t52PqTRgrv0ZWRaV893LQwKhgVhsYdR GNrJ2L/YkeLTyVW6XmcnsEP7IJp19G+mZiM5jX4lDqT8iKcghaG8AUpzTF1/Gewb9reS 8lb6yzFMa4IY+S4heRy0br5RCEFXrm+Eye3bfcT3iIp19DnOLaA/JBUUhp2ihznpriNd 2X2Ky3sz1Y/lDLBTxPrGWXpOnpaEUuMbEl2/faeFlIUQ+7R/G19mZJOWRAoaFkefZ3CM DeFw== X-Forwarded-Encrypted: i=1; AJvYcCUGH9Ubizw+/YbRxBSah3B9IaBZu0uM1P3k+Vu2nVC8Q6U1u/mnu8IJLnRCAwiGBQnduowDNBDueE5WaGo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2TyzEq9hv79sFcqfiQCz/muKfxqJu7jMGxcQLA+mqu4j5kEHa Ji3mds9bwWki0Kqdigmb3aOqkrhvtwPh/sAjsHvsb6GzLc5ZkAlU7UUg/M1K X-Gm-Gg: ASbGncsh599+IxHRPNRXL7QNGjIcyHChpacpwT2yYz7/JHeYGYQNBV/ujK/5zQw9IdK 5mxMALS6ZVHTHkjRJTIsHFgbh5sMQjtNViA2onvcmtWoyhsiE5tkMRnlTv9xX0qzeHgKAA/lp/D AiJ+SSJBltI5BbHWq22CIl0VdoA1x85EijVUKBBZEmk532Q2RuXQciOZQlL4ZoK5dDDTidl8miA yl/HOJQ7Xdfn75ytXYHnyvcGBAYDrgnAG/UzkwklCj/fsaUnDnY64A= X-Google-Smtp-Source: AGHT+IFvF6NazmgBMZtn6N3YueQInbnzxTDwbrKgIMEWlCqAUdHFmci1WI98dcBWquRlmr4b9CpDCg== X-Received: by 2002:a17:903:2345:b0:215:435d:b41a with SMTP id d9443c01a7336-219e6e857b8mr150776455ad.1.1735367165378; Fri, 27 Dec 2024 22:26:05 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f73f6sm144479455ad.222.2024.12.27.22.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 22:26:05 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v5 09/15] staging: gpib: hp_82335: Return error value from gpib_register_driver() Date: Sat, 28 Dec 2024 11:37:57 +0530 Message-Id: <20241228060800.107653-10-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241228060800.107653-1-niharchaithanya@gmail.com> References: <20241228060800.107653-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function gpib_register_driver() can fail and does not return an error value if it fails. Return the error value if gpib_register_driver() fails. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/hp_82335/hp82335.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gpib/hp_82335/hp82335.c b/drivers/staging/gpib/hp_82335/hp82335.c index 40afe42aea47..af8ddc173d12 100644 --- a/drivers/staging/gpib/hp_82335/hp82335.c +++ b/drivers/staging/gpib/hp_82335/hp82335.c @@ -325,7 +325,14 @@ void hp82335_detach(gpib_board_t *board) static int __init hp82335_init_module(void) { - gpib_register_driver(&hp82335_interface, THIS_MODULE); + int result = gpib_register_driver(&hp82335_interface, THIS_MODULE); + + if (result) { + pr_err("hp82335: gpib_register_driver failed!\n"); + return result; + } + + pr_info("hp82335: module init is complete\n"); return 0; } -- 2.34.1