From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31ACF35960 for ; Sat, 28 Dec 2024 06:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735367146; cv=none; b=Cvf4bV4iknW2+xpULV6wSu1w0KLciGa1lMPWmME0ka2rrsXL7ULj13MjIZjzO10sudd+9xuV/+y0/IF5ALh+oFSyLoELlVxhHy/zD7X77k5wZHF96opXUJcmEzAfGc2/aRWL3Ii2BjbDSuk7D5MeMVkukVcWwqbMHNj4IRR/boM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735367146; c=relaxed/simple; bh=hUxZ8FrvpBx9aXpZcCXs3Uo5cPIbsMPecSxvj8HGdKg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Cwib7hxbWWW9Ao1O74irzb/UvP4rxKJFPz7bppxPeOaCtKP2fEB2sYFl5ZWqxCVsyxJfrBkz5RpQzaWO8Of8JuGleHjvzrCK4sfdNApeF196BHouZb67qHdfFl2BVgbtWFn51q6HVJh1l9skW4RyNwAGb8mvjPed8aV0aCqzn64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SQooAr/5; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SQooAr/5" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2f2f5e91393so1329447a91.0 for ; Fri, 27 Dec 2024 22:25:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735367144; x=1735971944; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CLv/TrsqKNLXFPXLidmCmK90WVqyL60WkqeVoeLIKIs=; b=SQooAr/5CkouVszMV4T90MQtvJsOFT/O1qaLCKygD2Isaq7eS70GtBStDOiFU6760e cgAE20u620/g97Ue+N+GfU5SCmT4nj7jT9UdT4OrgFQpQW+e/S6QaYh+IIzICf2HcpYQ hrm30ArnxKSvWsUu1CLYN8H8/npe2x3iRK/a8jAImwwpFrEKFGhp2O9Ibnm8hZDTqWS1 tNqpGyEInNi0FLt+H0j3yamn2DWrA604BxRaId8NhF0WYTyENfx8ID307px6mxBPoozG YvP3nVAfw9qJAAQ4+PWPo79gzpm7JbJ6JsXPPi0VD6c3YNBwoxRtnoCHnAB0H4IrRPph rbWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735367144; x=1735971944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CLv/TrsqKNLXFPXLidmCmK90WVqyL60WkqeVoeLIKIs=; b=lkptCSL5YNS5TS1Y1VaMgZlnhO9gIOk2iZp2+YLjcIFGPawXI+BYRoXwRL7Y/Ou0cM /pmD8w4cjSei9UjxhFxLf40TxLEDT4Y7tiQkKaJ0gz5o2bq2zLVPZ9wDwAsPpX4StAxq 85uBZ0DcMqNdTq1GS4pPvcDL2CZo+w+TlZ77+IYY548MGHfTazraog0yH626MaGaca7s lq4dY0dKTYOUcegYU7EpnEGYbmHcPR/HWjvyidYrU67LAtypBn0Gbu8DYeCT3M93EnA8 EMg5F9aZgYMb/J5DGdhIm4qwLszyUDEqe0jnwc5D/k/FEoPxhWljQRQ/oVacfM2ugpTp nRLA== X-Forwarded-Encrypted: i=1; AJvYcCVnec8mt0odkRVVVY3V+wxOnXGhqNg9iH4ssnjE4jOb1X6WV3riHDTLSg8ubPZ1T7gxTy897zIc11qLwdc=@vger.kernel.org X-Gm-Message-State: AOJu0YwVoQ7gBd2KPk2oN7IqFFf0k8zxkPCEAo1Aw+EtTCUAsXm1+Rk8 w1ZGq26zIFZO6dWTeZOATRVuWCReYyb0gZSF8zPvFgLUc9BMD8IU X-Gm-Gg: ASbGncvOvkf9GfoTo/DWEOJq22ebTgOeGweXnidhSwi0djEpwf4yP61G8bHnHLi3Rm/ 6UY7qk3fdCUPmdc0Ei7zvdqEmhKuP5AP561wzfnf8W+yEZ2N2FJOmjiHPAwHnKVw+MiKU4vVh5C ia1mQNoUoLfFlML/ySoFZBo2DUS2h/ge+EVi6W86GPbFL8s0NyNFfIfMwM95z54pPsOAFTtgBpM sAm9VSoHVgtSpxKZ6pPQ5d4/qHqmNTNBFBX/yPIRZj2LaprpPKpbxc= X-Google-Smtp-Source: AGHT+IG6+h6YfUGxLZ2dRC+aXcdBRJjWHdaWKAQHDgTLK7vryRIgHyU98oxdi8ypalEacL9fGWFH0A== X-Received: by 2002:a17:902:f64b:b0:216:30f9:93c5 with SMTP id d9443c01a7336-219e6e9e81fmr156977005ad.6.1735367144443; Fri, 27 Dec 2024 22:25:44 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f73f6sm144479455ad.222.2024.12.27.22.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 22:25:44 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v5 01/15] staging: gpib: Modify gpib_register_driver() to return error if it fails Date: Sat, 28 Dec 2024 11:37:49 +0530 Message-Id: <20241228060800.107653-2-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241228060800.107653-1-niharchaithanya@gmail.com> References: <20241228060800.107653-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function gpib_register_driver() can fail if kmalloc() fails, but it doesn't return any error if that happens. Modify the function to return error i.e int. Return the appropriate error code if it fails. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/common/gpib_os.c | 7 ++++--- drivers/staging/gpib/include/gpibP.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/gpib/common/gpib_os.c b/drivers/staging/gpib/common/gpib_os.c index 405237d8cb47..07795df3b721 100644 --- a/drivers/staging/gpib/common/gpib_os.c +++ b/drivers/staging/gpib/common/gpib_os.c @@ -2094,18 +2094,19 @@ void init_gpib_descriptor(gpib_descriptor_t *desc) atomic_set(&desc->io_in_progress, 0); } -void gpib_register_driver(gpib_interface_t *interface, struct module *provider_module) +int gpib_register_driver(gpib_interface_t *interface, struct module *provider_module) { struct gpib_interface_list_struct *entry; entry = kmalloc(sizeof(*entry), GFP_KERNEL); if (!entry) - return; + return -ENOMEM; entry->interface = interface; entry->module = provider_module; list_add(&entry->list, ®istered_drivers); - pr_info("gpib: registered %s interface\n", interface->name); + + return 0; } EXPORT_SYMBOL(gpib_register_driver); diff --git a/drivers/staging/gpib/include/gpibP.h b/drivers/staging/gpib/include/gpibP.h index 5fc42b645ab7..d0cd42c1a0ad 100644 --- a/drivers/staging/gpib/include/gpibP.h +++ b/drivers/staging/gpib/include/gpibP.h @@ -17,7 +17,7 @@ #include #include -void gpib_register_driver(gpib_interface_t *interface, struct module *mod); +int gpib_register_driver(gpib_interface_t *interface, struct module *mod); void gpib_unregister_driver(gpib_interface_t *interface); struct pci_dev *gpib_pci_get_device(const gpib_board_config_t *config, unsigned int vendor_id, unsigned int device_id, struct pci_dev *from); -- 2.34.1