From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F0FA86339 for ; Sat, 28 Dec 2024 06:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735367157; cv=none; b=bxt0t72usYnK+/et1zidxK1/kUUsuFifUNkYvD4tQNAdFj0LXMP9taLhi8qX4/yjwDO6AIWx7I2xbUBaXQHbUVnrQVIC4crEaNz0SxH9ixZv0jIC6HLBcBAshb0xxZneN2VI+SZ5L281ulkPBi/ocaKmPoPKSmnFKVrnsCxgVQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735367157; c=relaxed/simple; bh=DiRa9ccQiQCl1NUp1iOeJ2P/1FNzMtrAQ1t/b/E9lew=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qifd4b6ZGXG1uA+ymutEX8FNgyNwqPoHPs/tz8XC3LkncsVCSPj6YgXnK2JBqJVm+FPfVvtzykrjBmAlp3613M3ZrSOKuq5UsUNI547nOkBSrbIreKhojK/hZR9nfJ9FBHyzETA1r3YiA+TllzFUmo8K/oXszjA6o2QYeH2bme8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M76DsqBu; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M76DsqBu" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2f45244a81fso1246736a91.1 for ; Fri, 27 Dec 2024 22:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735367155; x=1735971955; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U1VfslPjbzPmT9c9bSTxnlZCAB7dXV/7Mr2zyjVr3jQ=; b=M76DsqBug0NOfXa+ZiCRc862BvthwuWwLn3NHu5hfZQFz9P/F9WVwf7sQNqcal9tUN MGMUlYcGm1mOmaJchmxuCoHgLFR/C/JRrC+IMFfyoZVlRinNTHQ3GT7KNR+qMuxfBObK 4n2YS/j3GBNJzb044jFj1CPWlP/m7uEcni33Fdzy8hjBWJcV7lKEf8C0UpGh6v5pdjJE 5/onvWfb3uVAUEOCi1yPcLaDN1Z8qRQhzhkdRqGcFsj6IU5RKl6VFbKa6SRsnOQqbCQb zMj42GjEozuvcub083TqoJT7EogjL6kFqsw4Dx7Cdv9qAAS6+CYtv5hqU+2D46qC4RD4 sdgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735367155; x=1735971955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U1VfslPjbzPmT9c9bSTxnlZCAB7dXV/7Mr2zyjVr3jQ=; b=XIpGAkCwByi22J1GqGAtv8UL3NiCk+yFGLdzLawycx1BMRHY4Jxht2bHaYUcQTBhlt u0mgMdTnoGpVVDrkb1rpvdMxWUjp9UTfxrlWv1VmVvapI4CVr8/JbQyfQWzdRrjw6Zmi SMK6Pc93ay0nZjfjjoG87E4HfBAoOrXrU10qRWsWzWAFlLS/XrJ8BPFzV0GTE0pOZ4m9 xxNa7owrWnKBwvnjbS95QyZxuJWMB8EWPMXGOW4SEOLC7XtYhqvFAwhrChdl7w+rGuM0 xiBtlv1BpvI5iMwVekcmBpd91VboBgOFpW1wToD/8LPSXU6fRWyQqEfnGKImZnU3U/zT UGTg== X-Forwarded-Encrypted: i=1; AJvYcCU4BA+mgYr1q6hm8I6TMtz9uHvGNL7mkVHD1dDCfS75m5skq9wVCdXSJRnMtXDI3y7CmM5noCCsKFzRjvg=@vger.kernel.org X-Gm-Message-State: AOJu0YwZGsHIDXBfnpQ7AExURCwId1woNiabhpuSL0WCLgjZ0YvfDXpg I84g3xRzsy18UlVbqstsJf062KD5cs0fvSgL7UqZphx4Xyer+s6G X-Gm-Gg: ASbGncsX/m/ONCkn3nSroHAnxVZHWWCrLChXz2ODrl3/Yo9WXvm2vGfJ/CT327HC49O V0p6yL5r1AKKVTIwyVGNBCCvK+25mrbbJ/kHH7YIQJX69wHJ/YBS/CHpefwWtXanSKXvAoQij0F NPO9Rfi1Qw/PKLnr8rSXCLi7Y19GbqWCqYR9JP3xXqLrYdwNaecPSxjWRx1mkHnDfqb237rwvJs 279zNlQx00MWiZJ3CV8lop3jOua66j5v4b+WpKFx8KPgf8zdDqy0jM= X-Google-Smtp-Source: AGHT+IEpBsBBwXgjpkbchPZlyJwMH+ROmQ94Asfaj950k2A6CiGmu5Q0PWz52PGm4iQlubWSeDxc6Q== X-Received: by 2002:a17:902:c408:b0:216:526a:5403 with SMTP id d9443c01a7336-219e6e887dbmr154779935ad.3.1735367155451; Fri, 27 Dec 2024 22:25:55 -0800 (PST) Received: from ice.. ([171.76.83.141]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc9f73f6sm144479455ad.222.2024.12.27.22.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 22:25:55 -0800 (PST) From: Nihar Chaithanya To: dpenkler@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, skhan@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nihar Chaithanya Subject: [PATCH v5 05/15] staging: gpib: cec: Handle gpib_register_driver() errors Date: Sat, 28 Dec 2024 11:37:53 +0530 Message-Id: <20241228060800.107653-6-niharchaithanya@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241228060800.107653-1-niharchaithanya@gmail.com> References: <20241228060800.107653-1-niharchaithanya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function gpib_register_driver() can fail and result in a semi-registered module and does not return an error value if it fails. Unregister the pci registering function in case gpib_register_driver() fails and return the error value. Signed-off-by: Nihar Chaithanya --- drivers/staging/gpib/cec/cec_gpib.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gpib/cec/cec_gpib.c b/drivers/staging/gpib/cec/cec_gpib.c index 3dc933deb401..5e887c649ddb 100644 --- a/drivers/staging/gpib/cec/cec_gpib.c +++ b/drivers/staging/gpib/cec/cec_gpib.c @@ -365,12 +365,17 @@ static int __init cec_init_module(void) result = pci_register_driver(&cec_pci_driver); if (result) { - pr_err("cec_gpib: pci_driver_register failed!\n"); + pr_err("cec_gpib: pci_driver_register failed: error = %d\n", result); return result; } - gpib_register_driver(&cec_pci_interface, THIS_MODULE); + result = gpib_register_driver(&cec_pci_interface, THIS_MODULE); + if (result) { + pr_err("cec_gpib: gpib_register_driver failed!\n"); + return result; + } + pr_info("cec_gpib: module init is complete\n"); return 0; } -- 2.34.1