Re: [PATCH 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC

[Pengyu Luo <mitltlatltl@gmail.com>]

On Sat, Dec 28, 2024 at 5:54 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 27/12/2024 18:13, Pengyu Luo wrote:
> > +
> > +description:
> > +  Different from other Qualcomm Snapdragon sc8180x sc8280xp based machines,
> > +  the Huawei Matebook E Go tablets use embedded controllers while others
> > +  use something called pmic glink which handles battery, UCSI, USB Type-C DP
> > +  alt mode. Huawei one handles even more, like charging thresholds, FN lock,
> > +  lid status, HPD events for the USB Type-C DP alt mode, etc.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - huawei,sc8180x-gaokun-ec
> > +          - huawei,sc8280xp-gaokun-ec
>
> sc8180x and sc8280xp are not products of Huawei, so you cannot combine
> them. Use compatibles matching exactly your device, because I doubt any
> of us has actual schematics or datasheet of that device.
>
> > +      - const: huawei,gaokun-ec
>
> How did you get the name?
>

From website of Huawei([1]), please search for 'gaokun' here, we can know
this series is called gaokun. Many files from windows indicate more,
someone fetch drivers from microsoft server([2]), in one of driver archive
'OemXAudioExt_HWVE.cab', there are two files, "algorithm_GaoKunGen2.xml"
"algorithm_GaoKunGen3.xml". And `Gaokun Gen3` print can be found on
motherboard(someone have the motherboard, I can ask for it later).

So can I use?
- enum:
	- huawei,gaokun-gen2
	- huawei,gaokun-gen3

Some backgroud:
There are 3 variants, Huawei released first 2 at the same time.
Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2.
Huawei Matebook E Go(sc8280xp@3.0GHz), codename is gaokun3.
Huawei Matebook E Go 2023(sc8280xp@2.69GHz).

> > +
> > +  reg:
> > +    const: 0x38
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  connector:
> > +    $ref: /schemas/connector/usb-connector.yaml#
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c15 {
>
> i2c
>

Agree

> > +        clock-frequency = <400000>;
> > +
> > +        pinctrl-names = "default";
> > +        pinctrl-0 = <&i2c15_default>;
>
> Drop all three above and test your bindings. This cannot work and test
> will tell you what is missing.
>

Agree

> > +
> > +        embedded-controller@38 {
> > +            compatible = "huawei,sc8280xp-gaokun-ec", ""huawei,gaokun-ec";
> > +            reg = <0x38>;
> > +
> > +            interrupts-extended = <&tlmm 107 IRQ_TYPE_LEVEL_LOW>;
> > +
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            connector@0 {
>
> Test your bindings - you do not have node connector@0.
>

I have rewritten it locally. So I will add the following and do some fixes
in v2.

patternProperties:
  '^connector@[01]$':
    $ref: /schemas/connector/usb-connector.yaml#

    properties:
      reg:
        maxItems: 1

>
>
> Best regards,
> Krzysztof

Thanks,
Pengyu

[1] https://consumer.huawei.com/en/support/content/en-us15945089
[2] https://github.com/matebook-e-go/uup-drivers-sc8280xp/releases