From: Kurt Borja <kuurtb@gmail.com>
To: platform-driver-x86@vger.kernel.org
Cc: Dell.Client.Kernel@dell.com, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org,
mario.limonciello@amd.com, w_armin@gmx.de,
Kurt Borja <kuurtb@gmail.com>, Armin Wolf <W_Armin@gmx.de>
Subject: [PATCH v2 01/20] alienware-wmi: Remove unnecessary check at module exit
Date: Sun, 29 Dec 2024 14:44:48 -0500 [thread overview]
Message-ID: <20241229194506.8268-3-kuurtb@gmail.com> (raw)
In-Reply-To: <20241229194506.8268-2-kuurtb@gmail.com>
Module initialization fails if platform device fails to register so it's
always not NULL at exit.
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
drivers/platform/x86/dell/alienware-wmi.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c
index e95d22c7b60c..ed66720260ab 100644
--- a/drivers/platform/x86/dell/alienware-wmi.c
+++ b/drivers/platform/x86/dell/alienware-wmi.c
@@ -1257,13 +1257,11 @@ module_init(alienware_wmi_init);
static void __exit alienware_wmi_exit(void)
{
- if (platform_device) {
- alienware_zone_exit(platform_device);
- remove_hdmi(platform_device);
- remove_thermal_profile();
- platform_device_unregister(platform_device);
- platform_driver_unregister(&platform_driver);
- }
+ alienware_zone_exit(platform_device);
+ remove_hdmi(platform_device);
+ remove_thermal_profile();
+ platform_device_unregister(platform_device);
+ platform_driver_unregister(&platform_driver);
}
module_exit(alienware_wmi_exit);
--
2.47.1
next prev parent reply other threads:[~2024-12-29 19:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 19:44 [PATCH v2 00/20] alienware-wmi driver rework Kurt Borja
2024-12-29 19:44 ` Kurt Borja [this message]
2024-12-29 19:44 ` [PATCH v2 02/20] alienware-wmi: Move Lighting Control State Kurt Borja
2024-12-29 19:44 ` [PATCH v2 03/20] alienware-wmi: Modify parse_rgb() signature Kurt Borja
2024-12-29 19:44 ` [PATCH v2 04/20] alienware-wmi: Improve hdmi_mux, amplifier and deepslp group creation Kurt Borja
2024-12-29 19:44 ` [PATCH v2 05/20] alienware-wmi: Improve rgb-zones " Kurt Borja
2025-01-02 15:44 ` Armin Wolf
2025-01-02 18:33 ` Kurt Borja
2024-12-29 19:44 ` [PATCH v2 06/20] alienware_wmi: General cleanup of WMAX methods Kurt Borja
2025-01-02 15:50 ` Armin Wolf
2024-12-29 19:44 ` [PATCH v2 07/20] alienware-wmi: Add a state container for LED control feature Kurt Borja
2025-01-02 16:07 ` Armin Wolf
2025-01-02 18:45 ` Kurt Borja
2025-01-02 19:20 ` Armin Wolf
2025-01-02 19:40 ` Kurt Borja
2024-12-29 19:44 ` [PATCH v2 08/20] alienware-wmi: Add WMI Drivers Kurt Borja
2025-01-02 16:16 ` Armin Wolf
2025-01-02 18:49 ` Kurt Borja
2024-12-29 19:44 ` [PATCH v2 09/20] alienware-wmi: Add a state container for thermal control methods Kurt Borja
2025-01-02 16:19 ` Armin Wolf
2025-01-02 18:52 ` Kurt Borja
2024-12-29 19:44 ` [PATCH v2 10/20] alienware-wmi: Refactor LED " Kurt Borja
2025-01-02 16:29 ` Armin Wolf
2025-01-02 19:36 ` Kurt Borja
2024-12-29 19:44 ` [PATCH v2 11/20] alienware-wmi: Refactor hdmi, amplifier, deepslp methods Kurt Borja
2024-12-29 19:44 ` [PATCH v2 12/20] alienware-wmi: Refactor thermal control methods Kurt Borja
2024-12-29 19:45 ` [PATCH v2 13/20] alienware-wmi: Split DMI table Kurt Borja
2025-01-02 16:36 ` Armin Wolf
2025-01-02 19:37 ` Kurt Borja
2024-12-29 19:45 ` [PATCH v2 14/20] MAINTAINERS: Update ALIENWARE WMI DRIVER entry Kurt Borja
2024-12-29 19:45 ` [PATCH v2 15/20] platform/x86: Rename alienware-wmi.c Kurt Borja
2024-12-29 19:45 ` [PATCH v2 16/20] platform/x86: Add alienware-wmi.h Kurt Borja
2025-01-02 16:43 ` Armin Wolf
2024-12-29 19:45 ` [PATCH v2 17/20] platform-x86: Split the alienware-wmi driver Kurt Borja
2025-01-02 16:49 ` Armin Wolf
2024-12-29 19:45 ` [PATCH v2 18/20] platform/x86: dell: Modify Makefile alignment Kurt Borja
2024-12-29 19:45 ` [PATCH v2 19/20] platform/x86: Update alienware-wmi config entries Kurt Borja
2025-01-02 16:57 ` Armin Wolf
2024-12-29 19:45 ` [PATCH v2 20/20] alienware-wmi: Update header and module information Kurt Borja
2025-01-02 15:50 ` [PATCH v2 00/20] alienware-wmi driver rework Armin Wolf
2025-01-02 19:41 ` Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241229194506.8268-3-kuurtb@gmail.com \
--to=kuurtb@gmail.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=w_armin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox