[PATCH v2] cifs: Improve SMB1 stat() to work also for paths in DELETE_PENDING state

Pali Rohár
2025-01-07T00:23:23Z

Windows NT SMB server may return -EBUSY (STATUS_DELETE_PENDING) from
CIFSSMBQPathInfo() function for files which are in DELETE_PENDING state.
When this happens, it is still possible to use CIFSFindFirst() fallback.
So allow to use CIFSFindFirst() fallback also for -EBUSY error.

This change fixes stat() to work also against Windows Server 2022 for files
in DELETE_PENDING state.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
Changes in v2:
* Extend comment
* Update on top of the v2 change:
cifs: Fix and improve cifs_query_path_info() and cifs_query_file_info()
---
fs/smb/client/smb1ops.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/smb/client/smb1ops.c b/fs/smb/client/smb1ops.c
index fef9d08d7bda..9805dd6fb1d0 100644
--- a/fs/smb/client/smb1ops.c
+++ b/fs/smb/client/smb1ops.c
@@ -582,9 +582,10 @@ static int cifs_query_path_info(const unsigned int xid,

/*
* Then fallback to CIFSFindFirst() which works also with non-NT servers
- * but does not does not provide NumberOfLinks.
+ * but does not does not provide NumberOfLinks. Also it works for files
+ * in DELETE_PENDING state (CIFSSMBQPathInfo() returns -EBUSY for them).
*/
- if ((rc == -EOPNOTSUPP || rc == -EINVAL) &&
+ if ((rc == -EOPNOTSUPP || rc == -EINVAL || rc == -EBUSY) &&
!non_unicode_wildcard) {
if (!(tcon->ses->capabilities & tcon->ses->server->vals->cap_nt_find))
search_info.info_level = SMB_FIND_FILE_INFO_STANDARD;
--
2.20.1