Re: [PATCH] ipmi: ssif_bmc: Move smbus_cmd assignment after cleanup

Quan Nguyen
2025-01-06T02:32:36Z

On 03/01/2025 20:01, Corey Minyard wrote:
> On Fri, Jan 03, 2025 at 10:44:46AM +0700, Quan Nguyen wrote:
>>
>>
>> On 01/01/2025 23:54, Cosmo Chou wrote:
>>> Move smbus_cmd assignment to the end of process_smbus_cmd() to ensure
>>> the new command is not lost when complete_response() is triggered.
>>>
>>
>> Thanks Cosmo for the catch.
>>
>> And, IMHO, the root cause is the memset() on part buffer called in
>> complete_response() is not quite correct. In the current implementation, the
>> complete_response() should only be called when the READ is completed, ie:
>> only on I2C_SLAVE_STOP of READ transaction, otherwise all the info of
>> current on-going request will be mistakenly cleared as in this case.
>>
>> This patch is good and I wonder if we can make this a bit further as below?
>
> Yes, this is probably more future proof.
>
> Can you send me a formal patch, with a "Found-by:" for Cosmo? I'll
> replace Cosmo's patch.
>

Thanks Corey,

Will send the formal patch later.

Thanks,
-- Quan