Re: [PATCH] ALSA: hda/realtek: Enable PC beep passthrough for HP EliteBook 855 G7

[kernel test robot <lkp@intel.com>]

Hi Maciej,

kernel test robot noticed the following build errors:

[auto build test ERROR on tiwai-sound/for-next]
[also build test ERROR on tiwai-sound/for-linus linus/master v6.13-rc5 next-20241220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Maciej-S-Szmigiero/ALSA-hda-realtek-Enable-PC-beep-passthrough-for-HP-EliteBook-855-G7/20250101-211902
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link:    https://lore.kernel.org/r/8be5018af1d2b26b495719b122eff0eaa1333561.1735737289.git.mail%40maciej.szmigiero.name
patch subject: [PATCH] ALSA: hda/realtek: Enable PC beep passthrough for HP EliteBook 855 G7
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250102/202501020133.m4CnVfKi-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250102/202501020133.m4CnVfKi-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501020133.m4CnVfKi-lkp@intel.com/

All errors (new ones prefixed by >>):

   sound/pci/hda/patch_realtek.c: In function 'alc285_fixup_hp_beep':
>> sound/pci/hda/patch_realtek.c:6946:9: error: expected ';' before '}' token
    6946 |         }
         |         ^


vim +6946 sound/pci/hda/patch_realtek.c

  6925	
  6926	static void alc285_fixup_hp_beep(struct hda_codec *codec,
  6927					 const struct hda_fixup *fix, int action)
  6928	{
  6929		if (action == HDA_FIXUP_ACT_PRE_PROBE) {
  6930			codec->beep_just_power_on = true;
  6931		} else  if (action == HDA_FIXUP_ACT_INIT) {
  6932	#ifdef CONFIG_SND_HDA_INPUT_BEEP
  6933			/*
  6934			 * Just enable loopback to internal speaker and headphone jack.
  6935			 * Disable amplification to get about the same beep volume as
  6936			 * was on pure BIOS setup before loading the driver.
  6937			 */
  6938			alc_update_coef_idx(codec, 0x36, 0x7070, BIT(13));
  6939	
  6940			snd_hda_enable_beep_device(codec, 1);
  6941	
  6942	#if !IS_ENABLED(CONFIG_INPUT_PCSPKR)
  6943			codec_warn(codec, "enable CONFIG_INPUT_PCSPKR to get PC beeps\n")
  6944	#endif
  6945	#endif
> 6946		}
  6947	}
  6948	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki