From: kernel test robot <lkp@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: drivers/android/binderfs.c:237: warning: Function parameter or struct member 'file' not described in 'binder_ctl_ioctl'
Date: Thu, 2 Jan 2025 12:38:02 +0800 [thread overview]
Message-ID: <202501021220.itBTTNCC-lkp@intel.com> (raw)
Hi Christoph,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 56e6a3499e14716b9a28a307bb6d18c10e95301e
commit: 1045a06724f322ed61f1ffb994427c7bdbe64647 remove CONFIG_ANDROID
date: 2 years, 6 months ago
config: csky-randconfig-r036-20230303 (https://download.01.org/0day-ci/archive/20250102/202501021220.itBTTNCC-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250102/202501021220.itBTTNCC-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501021220.itBTTNCC-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/android/binderfs.c:237: warning: Function parameter or struct member 'file' not described in 'binder_ctl_ioctl'
>> drivers/android/binderfs.c:237: warning: Function parameter or struct member 'cmd' not described in 'binder_ctl_ioctl'
>> drivers/android/binderfs.c:237: warning: Function parameter or struct member 'arg' not described in 'binder_ctl_ioctl'
drivers/android/binderfs.c:237: warning: expecting prototype for binderfs_ctl_ioctl(). Prototype was for binder_ctl_ioctl() instead
--
drivers/android/binder.c:260: warning: Function parameter or struct member '_proc' not described in 'binder_proc_unlock'
drivers/android/binder.c:260: warning: Excess function parameter 'proc' description in 'binder_proc_unlock'
drivers/android/binder.c:362: warning: expecting prototype for binder_node_unlock(). Prototype was for binder_node_inner_unlock() instead
drivers/android/binder.c:1182: warning: expecting prototype for binder_dec_ref(). Prototype was for binder_dec_ref_olocked() instead
>> drivers/android/binder.c:1848: warning: Function parameter or struct member 'file' not described in 'binder_task_work_cb'
>> drivers/android/binder.c:1848: warning: Excess struct member 'fd' description in 'binder_task_work_cb'
>> drivers/android/binder.c:2286: warning: Function parameter or struct member 'offset' not described in 'binder_ptr_fixup'
>> drivers/android/binder.c:2286: warning: Function parameter or struct member 'skip_size' not described in 'binder_ptr_fixup'
>> drivers/android/binder.c:2286: warning: Function parameter or struct member 'fixup_data' not described in 'binder_ptr_fixup'
>> drivers/android/binder.c:2286: warning: Function parameter or struct member 'node' not described in 'binder_ptr_fixup'
>> drivers/android/binder.c:2306: warning: Function parameter or struct member 'offset' not described in 'binder_sg_copy'
>> drivers/android/binder.c:2306: warning: Function parameter or struct member 'sender_uaddr' not described in 'binder_sg_copy'
>> drivers/android/binder.c:2306: warning: Function parameter or struct member 'length' not described in 'binder_sg_copy'
>> drivers/android/binder.c:2306: warning: Function parameter or struct member 'node' not described in 'binder_sg_copy'
drivers/android/binder.c:2802: warning: Function parameter or struct member 'procp' not described in 'binder_get_node_refs_for_txn'
drivers/android/binder.c:2802: warning: Excess function parameter 'proc' description in 'binder_get_node_refs_for_txn'
>> drivers/android/binder.c:3699: warning: Function parameter or struct member 'thread' not described in 'binder_free_buf'
vim +237 drivers/android/binderfs.c
3ad20fe393b310 Christian Brauner 2018-12-14 224
3ad20fe393b310 Christian Brauner 2018-12-14 225 /**
3ad20fe393b310 Christian Brauner 2018-12-14 226 * binderfs_ctl_ioctl - handle binder device node allocation requests
3ad20fe393b310 Christian Brauner 2018-12-14 227 *
3ad20fe393b310 Christian Brauner 2018-12-14 228 * The request handler for the binder-control device. All requests operate on
3ad20fe393b310 Christian Brauner 2018-12-14 229 * the binderfs mount the binder-control device resides in:
3ad20fe393b310 Christian Brauner 2018-12-14 230 * - BINDER_CTL_ADD
3ad20fe393b310 Christian Brauner 2018-12-14 231 * Allocate a new binder device.
3ad20fe393b310 Christian Brauner 2018-12-14 232 *
3ad20fe393b310 Christian Brauner 2018-12-14 233 * Return: 0 on success, negative errno on failure
3ad20fe393b310 Christian Brauner 2018-12-14 234 */
3ad20fe393b310 Christian Brauner 2018-12-14 235 static long binder_ctl_ioctl(struct file *file, unsigned int cmd,
3ad20fe393b310 Christian Brauner 2018-12-14 236 unsigned long arg)
3ad20fe393b310 Christian Brauner 2018-12-14 @237 {
3ad20fe393b310 Christian Brauner 2018-12-14 238 int ret = -EINVAL;
3ad20fe393b310 Christian Brauner 2018-12-14 239 struct inode *inode = file_inode(file);
3ad20fe393b310 Christian Brauner 2018-12-14 240 struct binderfs_device __user *device = (struct binderfs_device __user *)arg;
3ad20fe393b310 Christian Brauner 2018-12-14 241 struct binderfs_device device_req;
3ad20fe393b310 Christian Brauner 2018-12-14 242
3ad20fe393b310 Christian Brauner 2018-12-14 243 switch (cmd) {
3ad20fe393b310 Christian Brauner 2018-12-14 244 case BINDER_CTL_ADD:
3ad20fe393b310 Christian Brauner 2018-12-14 245 ret = copy_from_user(&device_req, device, sizeof(device_req));
3ad20fe393b310 Christian Brauner 2018-12-14 246 if (ret) {
3ad20fe393b310 Christian Brauner 2018-12-14 247 ret = -EFAULT;
3ad20fe393b310 Christian Brauner 2018-12-14 248 break;
3ad20fe393b310 Christian Brauner 2018-12-14 249 }
3ad20fe393b310 Christian Brauner 2018-12-14 250
3ad20fe393b310 Christian Brauner 2018-12-14 251 ret = binderfs_binder_device_create(inode, device, &device_req);
3ad20fe393b310 Christian Brauner 2018-12-14 252 break;
3ad20fe393b310 Christian Brauner 2018-12-14 253 default:
3ad20fe393b310 Christian Brauner 2018-12-14 254 break;
3ad20fe393b310 Christian Brauner 2018-12-14 255 }
3ad20fe393b310 Christian Brauner 2018-12-14 256
3ad20fe393b310 Christian Brauner 2018-12-14 257 return ret;
3ad20fe393b310 Christian Brauner 2018-12-14 258 }
3ad20fe393b310 Christian Brauner 2018-12-14 259
:::::: The code at line 237 was first introduced by commit
:::::: 3ad20fe393b31025bebfc2d76964561f65df48aa binder: implement binderfs
:::::: TO: Christian Brauner <christian@brauner.io>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-01-02 4:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202501021220.itBTTNCC-lkp@intel.com \
--to=lkp@intel.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox