From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx4.wp.pl (mx4.wp.pl [212.77.101.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 927971B6D18 for ; Fri, 3 Jan 2025 08:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.77.101.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735894779; cv=none; b=M2/a4He0y5QdO9AzDKn3Ph8pfgpR3JHzmFX0if1G6dl+Iq9nd5GSwwqxJ8gx2oTyNKdaKsOtpRakp2kRVUvUWYX5c7f+dKovM5x9qwDJ+IJMVO5G50U0yjwtEDBc4qHWKxgHOvZGFCzlMoqLaQETEGaXpo1exsl3Xw0m1pgID4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735894779; c=relaxed/simple; bh=qUPRZskHJ+euSey/AbshsXeYOEOd9FooAV00nZdOEOk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LXUIPbzyyf0wKUwGjOa+ESK0a094riXWCj7EkHCjF8FzXHdP+S/rKRMhEc7l31GHgGqjWDL3Cy1RjQoZAwq3N3BAHiph931D4XmW3OFIX5c6yioyJVhjJvlK7cLRfA8yWs3r7tY6R9PAr2+t6jihP773swZU8whOqXfvHFBwN6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl; spf=pass smtp.mailfrom=wp.pl; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b=1n7oKvDN; arc=none smtp.client-ip=212.77.101.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=wp.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wp.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wp.pl header.i=@wp.pl header.b="1n7oKvDN" Received: (wp-smtpd smtp.wp.pl 34948 invoked from network); 3 Jan 2025 09:59:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=20241105; t=1735894774; bh=/6yQLG0zTD1VR1PmHShGmYEioog5lHSHwLvLNKfLPLA=; h=From:To:Cc:Subject; b=1n7oKvDNnVxaMVmRIJKrHTPk0ORrMuwzU53cQyFe+KLn+lpQz6Ncs0cJVxA3v12BD RhdCd4bSsXPEJ6GLZMPkhsxi4CTk1NNnYh8y+dTkDS0bbw5KEi2xkRQu/csKNioGz1 7Kar3YsB2cpBklg7SURuGAohNpjquKPkpUxjgtGFJhgUILMeoaxGf4cLHzOgUoRmMi vQLJcKm13Eu2PuKw0t+/kUnlf51gOwFtZOsAKMrjckMnJxovJ92XpqzFa9lnqYXFJv 4tZqWzR3YCS6gWgSTm0yipdpVHsSG/g/0iFzi2uII5sHjsdqgjb73GVctuEwqOn/vP b/wlRKwtfjxUg== Received: from 89-64-0-140.dynamic.chello.pl (HELO localhost) (stf_xl@wp.pl@[89.64.0.140]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 3 Jan 2025 09:59:34 +0100 Date: Fri, 3 Jan 2025 09:59:34 +0100 From: Stanislaw Gruszka To: linux@treblig.org Cc: kvalo@kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] wifi: iwlegacy: Remove unused il_get_single_channel_number Message-ID: <20250103085934.GC94204@wp.pl> References: <20241226011355.135417-1-linux@treblig.org> <20241226011355.135417-3-linux@treblig.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241226011355.135417-3-linux@treblig.org> X-WP-MailID: 615016b2ae563662b85b48cd4b21a0e1 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [8bP0] On Thu, Dec 26, 2024 at 01:13:55AM +0000, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > THe last use of il_get_single_channel_number() was removed in 2011 by > commit dd6d2a8aef69 ("iwlegacy: remove reset rf infrastructure") > when it was still called iwl_legacy_get_single_channel_number. > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert Acked-by: Stanislaw Gruszka > --- > drivers/net/wireless/intel/iwlegacy/common.c | 31 -------------------- > drivers/net/wireless/intel/iwlegacy/common.h | 1 - > 2 files changed, 32 deletions(-) > > diff --git a/drivers/net/wireless/intel/iwlegacy/common.c b/drivers/net/wireless/intel/iwlegacy/common.c > index 958dd4f9bc69..af4f42534ea0 100644 > --- a/drivers/net/wireless/intel/iwlegacy/common.c > +++ b/drivers/net/wireless/intel/iwlegacy/common.c > @@ -3915,37 +3915,6 @@ il_set_rxon_ht(struct il_priv *il, struct il_ht_config *ht_conf) > } > EXPORT_SYMBOL(il_set_rxon_ht); > > -/* Return valid, unused, channel for a passive scan to reset the RF */ > -u8 > -il_get_single_channel_number(struct il_priv *il, enum nl80211_band band) > -{ > - const struct il_channel_info *ch_info; > - int i; > - u8 channel = 0; > - u8 min, max; > - > - if (band == NL80211_BAND_5GHZ) { > - min = 14; > - max = il->channel_count; > - } else { > - min = 0; > - max = 14; > - } > - > - for (i = min; i < max; i++) { > - channel = il->channel_info[i].channel; > - if (channel == le16_to_cpu(il->staging.channel)) > - continue; > - > - ch_info = il_get_channel_info(il, band, channel); > - if (il_is_channel_valid(ch_info)) > - break; > - } > - > - return channel; > -} > -EXPORT_SYMBOL(il_get_single_channel_number); > - > /* > * il_set_rxon_channel - Set the band and channel values in staging RXON > * @ch: requested channel as a pointer to struct ieee80211_channel > diff --git a/drivers/net/wireless/intel/iwlegacy/common.h b/drivers/net/wireless/intel/iwlegacy/common.h > index 725c2a88ddb7..92285412ab10 100644 > --- a/drivers/net/wireless/intel/iwlegacy/common.h > +++ b/drivers/net/wireless/intel/iwlegacy/common.h > @@ -1705,7 +1705,6 @@ int il_full_rxon_required(struct il_priv *il); > int il_set_rxon_channel(struct il_priv *il, struct ieee80211_channel *ch); > void il_set_flags_for_band(struct il_priv *il, enum nl80211_band band, > struct ieee80211_vif *vif); > -u8 il_get_single_channel_number(struct il_priv *il, enum nl80211_band band); > void il_set_rxon_ht(struct il_priv *il, struct il_ht_config *ht_conf); > bool il_is_ht40_tx_allowed(struct il_priv *il, > struct ieee80211_sta_ht_cap *ht_cap); > -- > 2.47.1 >