Re: [PATCH 14/14] scripts/sorttable: ftrace: Do not add weak functions to available_filter_functions

Steven Rostedt
2025-01-03T12:14:13Z

On Fri, 3 Jan 2025 12:41:40 +0100
Peter Zijlstra <peterz@infradead.org> wrote:

>
> > not sure why that fits the condition above for removal
>
> Check your build, if update_socket_protocol() is no longer in the symbol
> table for your vmlinux.o then the linker deleted the symbol and things
> work as advertised.
>
> If its still there, these patches have a wobbly.

There is a wobbly. I guess I eliminated all weak functions even if they
were still used :-p

Jiri, can you add this on top?

diff --git a/scripts/sorttable.c b/scripts/sorttable.c
index 506172898fd8..ebcd687a9f0e 100644
--- a/scripts/sorttable.c
+++ b/scripts/sorttable.c
@@ -523,7 +523,7 @@ static int parse_symbols(const char *fname)
uint64_t size;

/* Only care about functions */
- if (type != 't' && type != 'T')
+ if (type != 't' && type != 'T' && type != 'W')
continue;

addr = strtoull(addr_str, NULL, 16);

-- Steve