public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Christian Heusel <christian@heusel.eu>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: pacman-pkg: provide versioned linux-api-headers package
Date: Fri, 3 Jan 2025 22:05:13 -0700	[thread overview]
Message-ID: <20250104050513.GA1889730@ax162> (raw)
In-Reply-To: <20250103-kbuild-pacman-pkg-provides-v1-1-d568b4b9cfd5@weissschuh.net>

On Fri, Jan 03, 2025 at 07:20:23PM +0100, Thomas Weißschuh wrote:
> The Arch Linux glibc package contains a versioned dependency on
> "linux-api-headers". If the linux-api-headers package provided by
> pacman-pkg does not specify an explicit version this dependency is not
> satisfied.
> Fix the dependency by providing an explicit version.
> 
> Fixes: c8578539deba ("kbuild: add script and target to generate pacman package")
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Makes sense based on my understanding of provides.

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  scripts/package/PKGBUILD | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/package/PKGBUILD b/scripts/package/PKGBUILD
> index f83493838cf96ac9f209c6fc8f9b219705f9715b..dca706617adc76d01a09a86785815a48db15b099 100644
> --- a/scripts/package/PKGBUILD
> +++ b/scripts/package/PKGBUILD
> @@ -103,7 +103,7 @@ _package-headers() {
>  
>  _package-api-headers() {
>  	pkgdesc="Kernel headers sanitized for use in userspace"
> -	provides=(linux-api-headers)
> +	provides=(linux-api-headers="${pkgver}")
>  	conflicts=(linux-api-headers)
>  
>  	_prologue
> 
> ---
> base-commit: 0bc21e701a6ffacfdde7f04f87d664d82e8a13bf
> change-id: 20250103-kbuild-pacman-pkg-provides-06b02d213e75
> 
> Best regards,
> -- 
> Thomas Weißschuh <linux@weissschuh.net>
> 

  reply	other threads:[~2025-01-04  5:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-03 18:20 [PATCH] kbuild: pacman-pkg: provide versioned linux-api-headers package Thomas Weißschuh
2025-01-04  5:05 ` Nathan Chancellor [this message]
2025-01-05 14:21 ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250104050513.GA1889730@ax162 \
    --to=nathan@kernel.org \
    --cc=christian@heusel.eu \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=masahiroy@kernel.org \
    --cc=nicolas@fjasle.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox