Re: [PATCH 5.15 000/168] 5.15.176-rc1 review

Greg Kroah-Hartman
2025-01-09T11:08:12Z

On Mon, Jan 06, 2025 at 04:05:30PM -0700, Shuah Khan wrote:
> On 1/6/25 08:15, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.15.176 release.
> > There are 168 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 08 Jan 2025 15:11:04 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.176-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
>
> Build failed on my test system with this commit:
>
> 999976126ca826e40fd85007a1b325d83e102164
>
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.15.y&id=999976126ca826e40fd85007a1b325d83e102164
>
> Worked when I removed this commit.
>
> Errors:
> CC [M] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.o
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c: In function ‘dcn20_split_stream_for_odm’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1945:40: error: ‘const struct opp_funcs’ has no member named ‘opp_get_left_edge_extra_pixel_count’; did you mean ‘opp_program_left_edge_extra_pixel’?
> 1945 | if (opp && opp->funcs->opp_get_left_edge_extra_pixel_count
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | opp_program_left_edge_extra_pixel
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1946:48: error: ‘const struct opp_funcs’ has no member named ‘opp_get_left_edge_extra_pixel_count’; did you mean ‘opp_program_left_edge_extra_pixel’?
> 1946 | && opp->funcs->opp_get_left_edge_extra_pixel_count(
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | opp_program_left_edge_extra_pixel
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1948:41: error: implicit declaration of function ‘resource_is_pipe_type’; did you mean ‘resource_list_first_type’? [-Werror=implicit-function-declaration]
> 1948 | resource_is_pipe_type(next_odm_pipe, OTG_MASTER)) == 1) {
> | ^~~~~~~~~~~~~~~~~~~~~
> | resource_list_first_type
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1948:78: error: ‘OTG_MASTER’ undeclared (first use in this function); did you mean ‘IFF_MASTER’?
> 1948 | resource_is_pipe_type(next_odm_pipe, OTG_MASTER)) == 1) {
> | ^~~~~~~~~~
> |

This took me a while to figure out, turns out that it's only built if
KCOV_INSTRUMENT_ALL is disabled as it looks like this code is really
sensitive to compiler issues. None of my test builds caught it at all,
thanks!

I'll go drop the offending commit now.

greg k-h