From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CABC1DE89C for ; Mon, 6 Jan 2025 18:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736186643; cv=none; b=azBJ59/AozJqTVNY9DixRScR/3kTAe6AA+xJ/YK3//vdCCAVz6vQgqJ8X3SdkS5nUwvKmG+KRyzsQkPUuH9thHEOplQCVpSO2SfTOgVb43hSQ+aMSiIMGD0GeLymB6mV0eL1gDBlxaiZnDw50BDb5CSrfpKtAkdBQkcipX3r7zI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736186643; c=relaxed/simple; bh=6UyIiv1Dw4fgKeT+R0JQZWnxh/MGDXA/pRrNEJtW8so=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gh4EvMTwtC7OCqoLir5dOBereodKzJNHIuuMeKyf73scAltwsuiNT4hdVWOLXM+Hnv2NtE1iw0tzoWE1J9es0SaY+NUDCqNd/djrzqjflMWIBiZVvFGMwxaUqMBBII7xSGA1PxJcxp+z3IpPFL3aGIRIpbaiPWW3FBrxXzi4iPE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DMq/6DzZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DMq/6DzZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736186640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AL9NesS086lBbDA2YUWQ7QfK7ZZ4IXXgIvT1iXWO99A=; b=DMq/6DzZoLl+rmf7k0FMmSbUaU9Kt8lx5FRDZPgmXX+20K06vHfdZlfiR+eFkeYSdFPdgJ r2hASqXs7CwGRBFrBFFxjsV8yRnPt+BVgGJs0bssrLCmQaaWGOASyy8lraS55KalCM1pOC MopSsQz4H5i7k0M9Li0lIEkO6G5OEXI= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-483-AFY-qNluPcONVozdYe5iBA-1; Mon, 06 Jan 2025 13:03:57 -0500 X-MC-Unique: AFY-qNluPcONVozdYe5iBA-1 X-Mimecast-MFC-AGG-ID: AFY-qNluPcONVozdYe5iBA Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6BE9F1956053; Mon, 6 Jan 2025 18:03:55 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.102]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 67EA9195605F; Mon, 6 Jan 2025 18:03:51 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 6 Jan 2025 19:03:30 +0100 (CET) Date: Mon, 6 Jan 2025 19:03:25 +0100 From: Oleg Nesterov To: Linus Torvalds Cc: Manfred Spraul , Christian Brauner , David Howells , WangYuli , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: wakeup_pipe_readers/writers() && pipe_poll() Message-ID: <20250106180325.GF7233@redhat.com> References: <20241229135737.GA3293@redhat.com> <20250102163320.GA17691@redhat.com> <20250106163038.GE7233@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250106163038.GE7233@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 On 01/06, Oleg Nesterov wrote: > > To be honest, I don't understand the wait_address check in poll_wait(), > it seems that wait_address is never NULL. Yes, $ git grep -E '\bpoll_wait\(' | perl -wne '/\(.*?,\s*\&/ or print' doesn't find anything "interesting". I think the wait_address check should die, it only adds the unnecessary confusion. Oleg.