From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA654CA64 for ; Mon, 6 Jan 2025 16:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736180705; cv=none; b=TkQZUV9NH5JauW30ZMu0+bZMlio1p79PGVl4m1yAH66eBm84TVb0OFhgxQDaBXKw8Js9zYjsMorlOxhanbj+NsoXbGM/6ICPz+sVgBxle5RcpV11YNi4EeKJvFFO0vAIIqEfS5O2f9p2R0egCKt4FaZvv110L9sNAKrQUEsUyds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736180705; c=relaxed/simple; bh=PHIwmrWLWJ4JoDy4VPzcu8Inmv94Qvylv8WLIslvdag=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GrYVe83dCtdDxURzjYejV3lCSeC7vjeiKP3Z5AfYjx4QDmsb3RKfsoyEHK4+yF5NT3Ni91B9EiO3X237cpUfNUxlCCHqoUyKc9qqG/8MCJcfZiySBsKaMIDovQsQuomm9wbF6CnP8tBG8XWB2+SWeVRGDw4GHKepercEWbG7mAM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oZL+5VcJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oZL+5VcJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1972EC4CED2; Mon, 6 Jan 2025 16:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1736180705; bh=PHIwmrWLWJ4JoDy4VPzcu8Inmv94Qvylv8WLIslvdag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oZL+5VcJfhjHzMsyNiP6QgLScc2zHIVxXeuedBJ/+wbUBO95VDA/x8pZksPT2E2nW Sp9L2LkW9yjSZcJcx39O3W4HVGu6zai3v4lxcCfgXCSt3UQhwtwMK8DD1jytjE1M2t DEMBctrazmBpL/WBd2j850m+a2GrFivck2LkQq2E= Date: Mon, 6 Jan 2025 17:25:02 +0100 From: Greg KH To: Harshit Mogalapalli Cc: cve@kernel.org, vegard.nossum@oracle.com, linux-kernel@vger.kernel.org, Martin Petersen , skashyap@marvell.com, qutran@marvell.com, Himanshu Madhani Subject: Re: [PATCH] CVE-2024-26929: Add vulnerable commit information Message-ID: <2025010651-hedging-scrimmage-2509@gregkh> References: <20250102204826.4132786-1-harshit.m.mogalapalli@oracle.com> <2025010329-kelp-chump-18ac@gregkh> <29eba901-ef67-41e6-b2a5-3f653861874d@oracle.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29eba901-ef67-41e6-b2a5-3f653861874d@oracle.com> On Fri, Jan 03, 2025 at 01:53:19PM +0530, Harshit Mogalapalli wrote: > Hi Greg, > > +CC qla2xxx experts > > On 03/01/25 12:22, Greg KH wrote: > > On Thu, Jan 02, 2025 at 12:48:26PM -0800, Harshit Mogalapalli wrote: > > > This CVE fixes: 4895009c4bb7 ("scsi: qla2xxx: Prevent command send on > > > chip reset") so add that information in vulnerable commit. > > > > > > Signed-off-by: Harshit Mogalapalli > > > --- > > > cve/published/2024/CVE-2024-26929.vulnerable | 1 + > > > 1 file changed, 1 insertion(+) > > > create mode 100644 cve/published/2024/CVE-2024-26929.vulnerable > > > > > > diff --git a/cve/published/2024/CVE-2024-26929.vulnerable b/cve/published/2024/CVE-2024-26929.vulnerable > > > new file mode 100644 > > > index 000000000000..b946d6f2786b > > > --- /dev/null > > > +++ b/cve/published/2024/CVE-2024-26929.vulnerable > > > @@ -0,0 +1 @@ > > > +4895009c4bb72f71f2e682f1e7d2c2d96e482087 > > > -- > > > 2.46.0 > > > > > > > > > > Ok, by doing this it means this whole CVE needs to be rejected as the > > vulnerable commit never shows up in a a release on its own. Are you > > sure about this? If so, let's just reject the CVE. > > > > My reasoning is as follows: > > The CVE fix commit: 82f522ae0d97 ("scsi: qla2xxx: Fix double free of > fcport") states, > > "" > Remove one of the free calls and add check for valid fcport. Also use > function qla2x00_free_fcport() instead of kfree(). > > @@ -2784,7 +2786,6 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int > els_opcode, > fcport->d_id.b.area, fcport->d_id.b.al_pa); > > wait_for_completion(&elsio->u.els_logo.comp); > - qla2x00_free_fcport(fcport); > > /* ref: INIT */ > kref_put(&sp->cmd_kref, qla2x00_sp_release); > > "" > > and the same function has this sp->free = qla2x00_els_dcmd_sp_free; so > fcport is freed twice. > > and this qla2xxx_free_fcport(fcport) in the success path is added by commit: > 4895009c4bb7 ("scsi: qla2xxx: Prevent command send on chip reset") so I > think this commit introduced the problem. Thanks for this, I've now rejected the cve entirely. greg k-h