From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAB291DE89C for ; Tue, 7 Jan 2025 11:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736248071; cv=none; b=SVG+wTrEct3lYcML745viQdPkCXXHdm8sftx3/SDxpIw3b+xTqDD/2wx/HZUkgjvpwdqeM40qekkZDXc+sV/ZhWSmjIFzGQbWV+TidyHWCDpeGiiQguPM5FrkQIUgmQN1j2xmpV2H+TsyPGOH3a/H3i9kzn2yRZFQM8h2tnKH1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736248071; c=relaxed/simple; bh=o3FTOB+sr4GnDY0MpWm24nUgNd1P/x6OuEWZoji6Xcs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=MC0YfnZxBolgEoZnu9ozAOBNLAoY9MEiJrEx6I40ME2j/YpwwzPIhRxfLwqcbFUYZ4Ho3n901w/08ULMKMAQV+nq5QK9t2O+NJck5fyFGfPJaj3NrITrpFwZBsJmNZWQswli0WwUOUMQoTK5X10/9m2aYcpmA9dOrXgmhoK1mrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mKyO9+KZ; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mKyO9+KZ" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-21631789fcdso164634355ad.1 for ; Tue, 07 Jan 2025 03:07:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736248068; x=1736852868; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+gpidHg4ZEv86QzDzlKxlsaugZmzV8W/+flQ1q2lIWg=; b=mKyO9+KZKd2nN8A5L/8HrLdcnH8cGIPPkDxEJiUwkdPs+tfQGuP42rdpdAG6lSxeXH wfm9iyhCqyYwiGDym/VXQ+mZLvJDOjxwJX7RMvWXj7lZ8Qw/nAze9t24gJ955LSCy5/m 9Szr1NzmKAF+I0c5q6KmzcK0WjRVAQSaUA/jpKUT1rykvCTc5x9zdYEFiY7wFYrkkedE CWURgcweLgJE9VGX0yTdGqiDdIPC0pQOApm7DkEo1lIbgK5my8UNsoj8dB+qG7pRNL1L VAKQ0FK2w6yl4FsdBRhVV87u5kaSjfKpAab5/1dG/nziuexX37kPcs5CjtardTxToTTk 6xtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736248068; x=1736852868; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+gpidHg4ZEv86QzDzlKxlsaugZmzV8W/+flQ1q2lIWg=; b=ML83+f+peMZDPS2MKcJkcD3mxxi1DYdVVDvhtNdAiBwRiGSsx3rGvOD0Loie1tZTyT Dfb2oua0GtME0aWmkHQwvkFHqtV3WGRfs39px84pN99vFYCZtn9s4NAjNMDMwvSl4RCE EytT17h3XwAzu99jNZfDO4uAKo//l4Z+gvTabgCc+woxpk1YcMyVz0xZDvy69ppx1DUO HlFfQh2Ii/zDGzu/4jjMyiZ4qy4qZLXfJ6CupNaJSZ1pawdp9tEr15uKAGYdJGbYFKpA aoPNUMqVvCrNkiGYqskJe1VmKJ7BEHi4Q/q41SwKMejMHj6W4rs2jp+u6UiVwS1816I0 S5pA== X-Forwarded-Encrypted: i=1; AJvYcCXD183x/kmZtjSHfKyBbXyfRbeXSDqTryzP0lXxCRNMxl9/3AcYzIb2apnHjgGOACpUf0Ukq27Z5DkdqJM=@vger.kernel.org X-Gm-Message-State: AOJu0YxP6rAuyFW3kqiC2+3iZ1dXfwlXgFBOzC3BVPtD2f/w9vrIixrB Iv4xXYiJJxISJJ7Usg5Z7epG266JrB2v2k3OfLtpF6oX6kPWbpMq X-Gm-Gg: ASbGnctCXHIN8DlPLLjN43Rv7KYYDXDW5s3Ah8Ovgxr2b8jlx6sGgVrrqISXAUqe3HJ 88ur8o4LRRPl5VLcZNcWPXF/Zy+32LqVW04OlheTCRWMkNUfsP9aKgCcp+QhEjgFJcJJ0MuyYHX tp7ZkwwuNHHbeBXIpv/5cMZTy2bablVoIXkPZzmHMqNL4t+yv29d9GNrXg8LfCjtsvukYxsinZi K652s6eIHTEuQfOe5KXKDOt/XxRuY+CmBhMsbWTyxjyXiF/LWtpoCu1cta6 X-Google-Smtp-Source: AGHT+IFnKr0prDsnls7vITkSRyba2ySXzsUmxWywh/xtaoNVIj9jHc51Feo+dXAMeTo2HxpTo+cGRA== X-Received: by 2002:a05:6a21:150a:b0:1e0:d5be:bf75 with SMTP id adf61e73a8af0-1e740119c52mr3471384637.17.1736248068019; Tue, 07 Jan 2025 03:07:48 -0800 (PST) Received: from HOME-PC ([223.185.133.12]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad815804sm33148964b3a.32.2025.01.07.03.07.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2025 03:07:47 -0800 (PST) From: Dheeraj Reddy Jonnalagadda To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dheeraj Reddy Jonnalagadda Subject: [PATCH drm-next] drm/bridge: it6505: Fix unreachable loop increment in KSV list check Date: Tue, 7 Jan 2025 16:37:40 +0530 Message-Id: <20250107110740.42892-1-dheeraj.linuxdev@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The inner loop in it6505_hdcp_part2_ksvlist_check had an unreachable increment due to returning true before the loop could continue. Restructure the loop to only return after verifying all 5 entries match, making the loop increment reachable. Fixes: 0989c02c7a5c ("drm/bridge: it6505: fix HDCP CTS compare V matching") Closes: https://scan7.scan.coverity.com/#/project-view/52337/11354?selectedIssue=1602785 Signed-off-by: Dheeraj Reddy Jonnalagadda --- drivers/gpu/drm/bridge/ite-it6505.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c index 88ef76a37fe6..2ff2245abdeb 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -2255,8 +2255,10 @@ static bool it6505_hdcp_part2_ksvlist_check(struct it6505 *it6505) av[i][1] != av[i][2] || bv[i][0] != av[i][3]) break; - DRM_DEV_DEBUG_DRIVER(dev, "V' all match!! %d, %d", retry, i); - return true; + if (i == 4) { + DRM_DEV_DEBUG_DRIVER(dev, "V' all match!! %d, %d", retry, i); + return true; + } } } -- 2.34.1