Re: [PATCH 07/10] Docs/mm/damon/design: document pass/block filters behaviors

SeongJae Park
2025-01-08T17:26:50Z

On Tue, 7 Jan 2025 20:04:54 -0800 SeongJae Park <sj@kernel.org> wrote:

> On Tue, 7 Jan 2025 12:17:36 -0800 SeongJae Park <sj@kernel.org> wrote:
>
[...]
> > +The fact that the action can be applied to any memory as long as no block
> > +filter explicitly excluded it means that installing pass filters without any
> > +block filter after those is same to not installing the pass filters, in terms
> > +of the ``action`` applying. Statistics for DAMOS filters will still be
> > +accounted, though.
>
> The above last sentence is right in a sense, but not useful and could only
> confuse readers. The statistics for DAMOS filters are filters passed size
> stat, which is provided as per-scheme accumulated stat and per-region instant
> information. The stat is for any memory that be able to apply the DAMOS action
> after the filters check stage. Hence, whether it has passed the stage due to
> existence of a pass filter that matches the memory, or the absence of any
> matching filter is distinguishable.
>
> > It is therefore still useful for monitoring purpose.
>
> Hence, the above sentence is completely wrong. The case (installing pass
> filtrs without any block filter after those) is not useful even for monitoring
> purpose.
>
> The RFC version of this patch was mentioning it correctly, but was not clearly
> describing why it is not also useless for even monitoring purpose. I was also
> confused due to the absence of the context. I will rewrite this part and send
> the whole series again as v2.

Another reason that I was confused is the conflict of the term. The term
'pass' at sz_filters_passed stat means passing through the filters checking
stage. The same term 'pass' at "DAMOS pass filter" means it will let the
memory that matches to its criteria pass the stage. Hence, the term for
'sz_filters_passed' is a superset of it for 'DAMOS pass filter'. This is
obviously confusing.

I will rename things that introduced by this series to be called "allow"
instead of "pass" in v2.

Thanks,
SJ

>
>
> Thanks,
> SJ
>
> …