From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D51E1F941E for ; Wed, 8 Jan 2025 12:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736337764; cv=none; b=knyMMg/gCoVdZIU/gDOCz5I3ymyF2YF0Weqo717JApbpO5YkfiyzZqahobJj9FI0K1Pnfl+TuHSI+PXUcDe2adtnM9Eflr9QDq1XlfQxi32bkJjUfB5B+DI/nr2SCY2CJUuOcuSDJkZfKH8lHzq/ocGqQVRL5q3eyb6Z/m/bcZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736337764; c=relaxed/simple; bh=IRcFUEnTe1JCKcKtnWX/qLTSGUTw9/fWw8tLCIvzbDU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Mmu0kHRL0/AsicrvMYWSFwJYGrictdvF9JOOTW8s6BJiG7ro1s8r+ESMhFhhqOuUAAq/pnhT+/l3inlGMVbMGz8e1chMia7a1pcyHN1fm7vOnTjmha/6gKQEEKl94+cIsKGOrCT0UyhEduP2zIPi5fkCkK0T9j6jpaJv1id+PeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bAzd69tB; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bAzd69tB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736337762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YLqYtIizfpzeEDN0YbG2hxxynEcPRAfxOqYGH5kCnXM=; b=bAzd69tBQLTMcryyJdGebVgj7FgnRZoP+l2YYpYiCTSXUGXBaGSQbJtB+xNQYie2Vtnqq+ FWjFGTukhXsLW9OLo1J28agJd8Mx4kcgNKBAK+ayr6JP3LfUNJ0jhl/ZYkpv5X7q2mjIoU 71i4VX0DJSpCNdf0+7yQyhnbjK34H4I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-7gLQ3EvLMIm8iFHBpxQz1w-1; Wed, 08 Jan 2025 07:02:40 -0500 X-MC-Unique: 7gLQ3EvLMIm8iFHBpxQz1w-1 X-Mimecast-MFC-AGG-ID: 7gLQ3EvLMIm8iFHBpxQz1w Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43582d49dacso112774505e9.2 for ; Wed, 08 Jan 2025 04:02:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736337759; x=1736942559; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YLqYtIizfpzeEDN0YbG2hxxynEcPRAfxOqYGH5kCnXM=; b=D0ZITHa88WnatqwWJIn+yCN5mME0MEeH1Wn0useodGEh7fxbkk6CuIrgbz4lTKm3ab QOWX/K5elCffDGHmfTbXEZnBXC4f2jZpoRKEqsWQwTkOm24qDlq7LjCJtDQ4wp6JStE6 BuC/ljrsWH3h9iL8aTaEnqeayNB0XQG3cRLyu6PBIYQ7Pd4La3a5Im8nVFfSnB8QQUpz mdGK4+hnPz9cmH+vsZBTh+gIRXt4Vu/WVRlUq+2DQyFcbrDZ1skBFcANpEWklDKX+WqP 4RQq7ZN8jZDBwrr0E/QVeOSFqI8q+dU9ckh42l2ivaFG8PNJi5IYCYjq2uGuNB+jCbgZ u3KA== X-Forwarded-Encrypted: i=1; AJvYcCVIBAKcwa0+E0Ms2KVwxjgINtwrIExPcWVf4aekrWNOuER1/mJkvjsWrTSxBNIG0EN5zfqOMTzlomqUxHc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2BNCSF944yQ7QWsbjtKVJIdHZYnTgH9cKUSxbLbZCD7PRHllf 0SEklpgDbmg/MNC9zcctTqnIrCFqy60zysDiZo7t3S+sX7Sm1DH/We5KUpeMsJURos5xaAAp16Y dNU8IakB2LGXlbtyKfYuAzYF7InsdafIymKuef4gDoOz/fG0SP0to+10SPGh2Iw== X-Gm-Gg: ASbGncuwIhs/wQnMLwo1OJirMJRJFuB3MWhxCWu3Ket7Aij762NyIYVoyByxTTPH+1E H3TcVhoA6WBTXl7SKHtVN5SH2anHoD0iD0uNeUyTNu+/VCqMyyI8sjjPD4cnJpK4DplUF3NyX9W Y8MxHyXgyqEwbgXHrRxfvhJ1bhfV3ozMGsMQPqDpPWnGYIOC68bOVIM+ZFoMOXMZhm/e9XPx9TA YyEuD1KTwFOHY60GXyD94eFkMGTg6hgfMA4zLYfxO9ydVK0bcg= X-Received: by 2002:a05:600c:46ce:b0:436:6ddf:7a27 with SMTP id 5b1f17b1804b1-436e27072a7mr17628615e9.23.1736337759391; Wed, 08 Jan 2025 04:02:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGScykllzbh31utZyOyhyPCeqeJOHfUUx2k3Z8hq3BxWlAiscDN3qnY2p23jYlKYf6YnAI+gQ== X-Received: by 2002:a05:600c:46ce:b0:436:6ddf:7a27 with SMTP id 5b1f17b1804b1-436e27072a7mr17628305e9.23.1736337758928; Wed, 08 Jan 2025 04:02:38 -0800 (PST) Received: from redhat.com ([2a02:14f:175:d62d:93ef:d7e2:e7da:ed72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2ddcf38sm18472675e9.20.2025.01.08.04.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 04:02:38 -0800 (PST) Date: Wed, 8 Jan 2025 07:02:33 -0500 From: "Michael S. Tsirkin" To: "Yuxue Liu yuxue.liu@jaguarmicro.com" Cc: jasowang@redhat.com, lkp@intel.com, angus.chen@jaguarmicro.com, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, xuanzhuo@linux.alibaba.com, oe-kbuild-all@lists.linux.dev, llvm@lists.linux.dev Subject: Re: [PATCH v2] vdpa/vp_vdpa: implement kick_vq_with_data callback Message-ID: <20250108070206-mutt-send-email-mst@kernel.org> References: <20241203023743.1757-1-yuxue.liu@jaguarmicro.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203023743.1757-1-yuxue.liu@jaguarmicro.com> On Tue, Dec 03, 2024 at 10:37:43AM +0800, Yuxue Liu yuxue.liu@jaguarmicro.com wrote: > From: Yuxue Liu > > Implement the kick_vq_with_data vDPA callback. > On kick, we pass the next available data to the hardware by writing it in > the kick offset. > > Signed-off-by: Yuxue Liu Pls do not send v2 as reply to v1. I am not sure all tools test the patch if you do. > --- > v2: fix build error for kernel test robot > > drivers/vdpa/virtio_pci/vp_vdpa.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c > index 16380764275e..8787407f75b0 100644 > --- a/drivers/vdpa/virtio_pci/vp_vdpa.c > +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c > @@ -367,6 +367,14 @@ static void vp_vdpa_kick_vq(struct vdpa_device *vdpa, u16 qid) > vp_iowrite16(qid, vp_vdpa->vring[qid].notify); > } > > +static void vp_vdpa_kick_vq_with_data(struct vdpa_device *vdpa, u32 data) > +{ > + struct vp_vdpa *vp_vdpa = vdpa_to_vp(vdpa); > + u16 qid = data & 0xFFFF; > + > + vp_iowrite32(data, vp_vdpa->vring[qid].notify); > +} > + > static u32 vp_vdpa_get_generation(struct vdpa_device *vdpa) > { > struct virtio_pci_modern_device *mdev = vdpa_to_mdev(vdpa); > @@ -472,6 +480,7 @@ static const struct vdpa_config_ops vp_vdpa_ops = { > .get_vq_size = vp_vdpa_get_vq_size, > .set_vq_address = vp_vdpa_set_vq_address, > .kick_vq = vp_vdpa_kick_vq, > + .kick_vq_with_data = vp_vdpa_kick_vq_with_data, > .get_generation = vp_vdpa_get_generation, > .get_device_id = vp_vdpa_get_device_id, > .get_vendor_id = vp_vdpa_get_vendor_id, > -- > 2.34.1