From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6841F1B394F for ; Wed, 8 Jan 2025 08:12:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736323974; cv=none; b=EIX4I1ZO7JsdnUrP6Zwo5XZqm/KXJRal2gz/EYgYwEdB0X61F9VUY/pqwUm7cwurcsY37jw3K7v3pSycHu1wnFplqm5WMBOabJki176Qh8X7zOi+2+WdHO7u01p+imJmBjGpY+WTKgabeg3nWy7/MOLIu9Q6CnpPtCYd938v/e4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736323974; c=relaxed/simple; bh=WRmkL+4symXQ+ONKJqDNAlYNMmru+NMXqDhNYOALqUY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=b0eE87iX65FQ2UJ4mpFfxaHTqS0LCcJWfzhYZd+oTokXWzROp6XQTg6pJrvI1zd4mU7hjXlR1mSCBH92Wq48n1MNNgljZ8pWQ6tN7hmQV6duHmXQZVM1JXQka1VQlXZPydAH2dOO3boSdacKuAcZqOyNa9Dbz555+U8o/vpAO+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=fHyYr319; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="fHyYr319" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736323970; bh=WRmkL+4symXQ+ONKJqDNAlYNMmru+NMXqDhNYOALqUY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fHyYr319dN6xUBlzHgKxLqclFeAO/h7rMpbNYYWxuQBtqoOgx/6OWb8FqTR1LbZpV Lum7mOU3rpVQ1OVbMhlM/CwLrCyLv8m1/lC3vNWZy0FotxcrHijH8q7irgz/FkhhVD 4mKz3r5RgWLbc3WjpgywJ1v6WVF/P+2bDE3vsQRnyJyrRXPzS0wwtLgrN7OYFoK+sq yVcX5E5RjRnYEwWO2ufWe/BdJujD0e1TXCrs3tqwT9tqkJZHRhYI7iDI8zrQyUGpXw 15+cAsP614BOHkIB6JYhJRaJ5QCCjPtbfbfo39sgP6FhAy95HqtDW09bxEToIat34v f1Wqh1Yp5D7kA== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 209B917E152A; Wed, 8 Jan 2025 09:12:50 +0100 (CET) Date: Wed, 8 Jan 2025 09:12:44 +0100 From: Boris Brezillon To: Florent Tomasin Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , , , Subject: Re: [PATCH] drm/panthor: Remove dead code Message-ID: <20250108091244.0a7eae0c@collabora.com> In-Reply-To: <20250107173310.88329-1-florent.tomasin@arm.com> References: <20250107173310.88329-1-florent.tomasin@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 7 Jan 2025 17:33:09 +0000 Florent Tomasin wrote: > Remove unused function declaration in panthor_gem.h: > - `panthor_gem_prime_import_sg_table()` > > Remove duplicate macro definitions: > - `MAX_CSG_PRIO` > - `MIN_CS_PER_CSG` > - `MIN_CSGS` > > Signed-off-by: Florent Tomasin Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panthor/panthor_fw.c | 1 - > drivers/gpu/drm/panthor/panthor_gem.h | 5 ----- > drivers/gpu/drm/panthor/panthor_sched.c | 3 --- > 3 files changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c > index 68eb4fb4d3a8..4a9c4afa9ad7 100644 > --- a/drivers/gpu/drm/panthor/panthor_fw.c > +++ b/drivers/gpu/drm/panthor/panthor_fw.c > @@ -201,7 +201,6 @@ struct panthor_fw_section { > > #define MIN_CS_PER_CSG 8 > #define MIN_CSGS 3 > -#define MAX_CSG_PRIO 0xf > > #define CSF_IFACE_VERSION(major, minor, patch) \ > (((major) << 24) | ((minor) << 16) | (patch)) > diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/panthor/panthor_gem.h > index e43021cf6d45..5749ef2ebe03 100644 > --- a/drivers/gpu/drm/panthor/panthor_gem.h > +++ b/drivers/gpu/drm/panthor/panthor_gem.h > @@ -85,11 +85,6 @@ struct panthor_gem_object *to_panthor_bo(struct drm_gem_object *obj) > > struct drm_gem_object *panthor_gem_create_object(struct drm_device *ddev, size_t size); > > -struct drm_gem_object * > -panthor_gem_prime_import_sg_table(struct drm_device *ddev, > - struct dma_buf_attachment *attach, > - struct sg_table *sgt); > - > int > panthor_gem_create_with_handle(struct drm_file *file, > struct drm_device *ddev, > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index 77b184c3fb0c..5844a7f639e0 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -88,9 +88,6 @@ > > #define JOB_TIMEOUT_MS 5000 > > -#define MIN_CS_PER_CSG 8 > - > -#define MIN_CSGS 3 > #define MAX_CSG_PRIO 0xf > > #define NUM_INSTRS_PER_CACHE_LINE (64 / sizeof(u64))