Re: [PATCH v3 00/10] DTS updates for system1 BMC

Ninad Palsule
2025-01-14T22:10:48Z

Hello Rob,

On 1/13/25 18:07, Rob Herring wrote:
>>> My bot found new DTB warnings on the .dts files added or changed in this
>>> series.
>>>
>>> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
>>> are fixed by another series. Ultimately, it is up to the platform
>>> maintainer whether these warnings are acceptable or not. No need to reply
>>> unless the platform maintainer has comments.
>>>
>>> If you already ran DT checks and didn't see these error(s), then
>>> make sure dt-schema is up to date:
>>>
>>> pip3 install dtschema --upgrade
>>>
>>>
>>> New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ibm-system1.dtb' for 20250108163640.1374680-1-ninad@linux.ibm.com:
>>>
>>> arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dtb: gpio@1e780000: 'hog-0', 'hog-1', 'hog-2', 'hog-3' do not match any of the regexes: 'pinctrl-[0-9]+'
>>> from schema $id: http://devicetree.org/schemas/gpio/aspeed,ast2400-gpio.yaml#
>> This is a false positive. So ignoring it.
> No, it is not. You need to define hog nodes in aspeed,ast2400-gpio.yaml.
> See other GPIO controller bindings that do this.

ok, I fixed it. Thanks for the review.

Regards,

Ninad

>
> Rob