Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp_id()

Wei Liu
2025-01-09T21:56:53Z

On Thu, Jan 09, 2025 at 01:40:34PM -0800, Roman Kisel wrote:
>
>
> On 1/9/2025 12:18 PM, Wei Liu wrote:
> > On Wed, Jan 08, 2025 at 02:21:33PM -0800, Roman Kisel wrote:
> > [...]
> > > Roman Kisel (5):
> > > hyperv: Define struct hv_output_get_vp_registers
> > > hyperv: Fix pointer type in get_vtl(void)
> > > hyperv: Enable the hypercall output page for the VTL mode
> > > hyperv: Do not overlap the hvcall IO areas in get_vtl()
> > > hyperv: Do not overlap the hvcall IO areas in hv_vtl_apicid_to_vp_id()
> >
> > The patches have been pushed to hyperv-next. Roman and Nuno, please
> > check the tree for correctness.
>
> This
>
> ```c
> union hv_arm64_pending_synthetic_exception_event {
> u64 as_uint64[2];
> struct {
> u8 event_pending : 1;
> u8 event_type : 3;
> u8 reserved : 4;
> u8 rsvd[3];
> u64 context;
> } __packed;
> };
> ```
>
> needs to have the `u32 exception_type;` field:
>
> ```c
> union hv_arm64_pending_synthetic_exception_event {
> u64 as_uint64[2];
> struct {
> u8 event_pending : 1;
> u8 event_type : 3;
> u8 reserved : 4;
> u8 rsvd[3];
> u32 exception_type;
> u64 context;
> } __packed;
> };
> ```
> as otherwise the struct won't cover the array.
> Testing the VMs currently with the latest hyperv-next.

Fixed. I c&p'ed the code then deleted the right version of the struct.
Thanks for checking.

Wei.