Re: [PATCH] Bluetooth: Allow reset via sysfs

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Jan 08, 2025 at 10:06:34AM -0500, Luiz Augusto von Dentz wrote:
> Hi Greg,
> 
> On Wed, Jan 8, 2025 at 7:34 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Jan 03, 2025 at 11:20:20AM +0800, Hsin-chen Chuang wrote:
> > > Allow sysfs to trigger reset via the cmd_timeout function in hci device.
> > > This is required to recover devices that are not responsive from
> > > userspace.
> > >
> > > Also remove the cmd timeout count in btusb since we only ever allow one
> > > command in flight at a time. We should always reset after a single
> > > command times out.
> > >
> > > Signed-off-by: Hsin-chen Chuang <chharry@chromium.org>
> > > ---
> > > This commit has been tested on a Chromebook by running
> > > `echo 1 > /sys/class/bluetooth/hci0/reset`
> >
> > You forgot the required Documentation/ABI/ update for your new sysfs
> > file :(
> 
> Looks like I've missed that when reviewing these changes, anyway no
> pull-request has been made, I assume we should follow what is
> documentation on Documentation/ABI/README?

Yes, all sysfs entries must be documented that way.  We have a script in
the tree that you can run to verify that all entries are documented, but
I don't think anyone runs it very often :(

> Does it include debugfs
> entries as well or only sysfs are required to be documented?

Only sysfs as that's the only stable api, debugfs can change all it
wants :)

thanks,

greg k-h