public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Damon Ding <damon.ding@rock-chips.com>
To: heiko@sntech.de
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	rfoss@kernel.org, vkoul@kernel.org,
	sebastian.reichel@collabora.com,
	cristian.ciocaltea@collabora.com, l.stach@pengutronix.de,
	dmitry.baryshkov@linaro.org, andy.yan@rock-chips.com,
	hjc@rock-chips.com, algea.cao@rock-chips.com,
	kever.yang@rock-chips.com, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-phy@lists.infradead.org,
	Damon Ding <damon.ding@rock-chips.com>
Subject: [PATCH v5 01/20] phy: phy-rockchip-samsung-hdptx: Swap the definitions of LCPLL_REF and ROPLL_REF
Date: Thu,  9 Jan 2025 11:27:06 +0800	[thread overview]
Message-ID: <20250109032725.1102465-2-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20250109032725.1102465-1-damon.ding@rock-chips.com>

According to the datasheet, setting the dig_clk_sel bit of CMN_REG(0097)
to 1'b1 selects LCPLL as the reference clock, while setting it to 1'b0
selects the ROPLL.

Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
index 0965b9d4f9cf..efbea5b67c89 100644
--- a/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
+++ b/drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
@@ -94,8 +94,8 @@
 #define LCPLL_ALONE_MODE		BIT(1)
 /* CMN_REG(0097) */
 #define DIG_CLK_SEL			BIT(1)
-#define ROPLL_REF			BIT(1)
-#define LCPLL_REF			0
+#define LCPLL_REF			BIT(1)
+#define ROPLL_REF			0
 /* CMN_REG(0099) */
 #define CMN_ROPLL_ALONE_MODE		BIT(2)
 #define ROPLL_ALONE_MODE		BIT(2)
-- 
2.34.1


  reply	other threads:[~2025-01-09  3:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-09  3:27 [PATCH v5 00/20] Add eDP support for RK3588 Damon Ding
2025-01-09  3:27 ` Damon Ding [this message]
2025-01-09  3:27 ` [PATCH v5 02/20] phy: phy-rockchip-samsung-hdptx: Supplement some register names with their full version Damon Ding
2025-01-09  3:27 ` [PATCH v5 03/20] phy: phy-rockchip-samsung-hdptx: Add the '_MASK' suffix to all registers Damon Ding
2025-01-09  3:27 ` [PATCH v5 04/20] phy: phy-rockchip-samsung-hdptx: Add eDP mode support for RK3588 Damon Ding
2025-01-09 12:39   ` Dmitry Baryshkov
2025-01-09  3:27 ` [PATCH v5 05/20] drm/rockchip: analogix_dp: Replace DRM_...() functions with drm_...() or dev_...() Damon Ding
2025-01-09  6:28   ` Andy Yan
2025-01-22  8:46     ` [PATCH " Damon Ding
2025-01-23 12:27       ` Jani Nikula
2025-01-24  9:41         ` Andy Yan
2025-01-24 10:55           ` Dmitry Baryshkov
2025-01-09  3:27 ` [PATCH v5 06/20] drm/rockchip: analogix_dp: Use formalized struct definition for grf field Damon Ding
2025-01-09  3:27 ` [PATCH v5 07/20] drm/rockchip: analogix_dp: Expand device data to support multiple edp display Damon Ding
2025-01-10  6:24   ` kernel test robot
2025-01-09  3:27 ` [PATCH v5 08/20] drm/bridge: analogix_dp: Add support for phy configuration Damon Ding
2025-01-09 12:41   ` Dmitry Baryshkov
2025-01-09  3:27 ` [PATCH v5 09/20] dt-bindings: display: rockchip: analogix-dp: Add support to get panel from the DP AUX bus Damon Ding
2025-01-09  3:27 ` [PATCH v5 10/20] drm/bridge: analogix_dp: support to get &analogix_dp_device.plat_data and &analogix_dp_device.aux Damon Ding
2025-01-09 12:42   ` Dmitry Baryshkov
2025-01-09 12:58   ` Dmitry Baryshkov
2025-01-09  3:27 ` [PATCH v5 11/20] drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus Damon Ding
2025-01-09 12:45   ` Dmitry Baryshkov
2025-01-22  8:06     ` Damon Ding
2025-01-09  3:27 ` [PATCH v5 12/20] drm/rockchip: " Damon Ding
2025-01-09 12:48   ` Dmitry Baryshkov
2025-01-22  8:17     ` Damon Ding
2025-01-22  9:37       ` Damon Ding
2025-01-22 18:56         ` Dmitry Baryshkov
2025-01-09  3:27 ` [PATCH v5 13/20] dt-bindings: display: rockchip: analogix-dp: Add support for RK3588 Damon Ding
2025-01-09  8:54   ` Krzysztof Kozlowski
2025-01-20  7:08     ` Damon Ding
2025-01-09  3:27 ` [PATCH v5 14/20] drm/bridge: analogix_dp: " Damon Ding
2025-01-09 12:49   ` Dmitry Baryshkov
2025-01-09  3:27 ` [PATCH v5 15/20] drm/rockchip: " Damon Ding
2025-01-09  3:27 ` [PATCH v5 16/20] drm/edp-panel: Add LG Display panel model LP079QX1-SP0V Damon Ding
2025-01-09  3:27 ` [PATCH v5 17/20] dt-bindings: display: rockchip: Fix label name of hdptxphy for RK3588 HDMI TX Controller Damon Ding
2025-01-09  3:27 ` [PATCH v5 18/20] arm64: dts: rockchip: Fix label name of hdptxphy for RK3588 Damon Ding
2025-01-09  3:27 ` [PATCH v5 19/20] arm64: dts: rockchip: Add eDP0 node " Damon Ding
2025-01-09  3:27 ` [PATCH v5 20/20] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board Damon Ding
2025-01-11 10:28   ` Andy Yan
2025-01-22  9:05     ` [PATCH " Damon Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250109032725.1102465-2-damon.ding@rock-chips.com \
    --to=damon.ding@rock-chips.com \
    --cc=algea.cao@rock-chips.com \
    --cc=andy.yan@rock-chips.com \
    --cc=conor+dt@kernel.org \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=krzk+dt@kernel.org \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox