From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D74B2215172 for ; Thu, 9 Jan 2025 09:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736413636; cv=none; b=LHpTdBpxEIj8FgTjelPc0rCwUlOM48IhCEU2+nM2VRdiu2kEEfg6HxENQiwxoBikjgq5t/Sdsjl49ROPJh5Gf43iji6NxSKcddxXoGFIJteW5r38ia3lcx1NdgqrLaEErbHyNA5PwzCIFhfe1dw2XyDXowwg6L3wi8e1TrI7EYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736413636; c=relaxed/simple; bh=HsTQiavqafw6fsPYuIFsCx4ppw/0+dyJq2Ei9ZnXIns=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fHEL6no7WHPST2yJ1HxyrevMIglFMo1taVKCVErs8A2nUXLftCUOBNT3NySdJlutJXC117nscpBFjZTRDAIY8oa3FYEj9C1fTs4kIigbnIoP2oJNl/SFF5zeeDZEh5hZ9XsS74ex9z0I2y1Ne2W7cDNaL3BClx8jKXgt1jmnEv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hdvuQYJL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hdvuQYJL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736413633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lPmn2NONYx2YB/n7h2bXDX/3a64ALTC7JSKNR4FIJZA=; b=hdvuQYJLvGZNAn3qGmvXx7q45AFJ88UZM7T7YaqRULXO8wr+dkFjvMYAhLnTA90ERzN55M Y6NNzIbgsFxYJeVsaDyx+Z7qd3FruF4OtTrO0NUk74LSkjhXx2DtGnvjnvkJPFYjzUywHv A9oKncXVEEepPdtkT0I7RtK2aIGMdDo= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-McOlSpgNP1ypz2wh0Do7cg-1; Thu, 09 Jan 2025 04:07:12 -0500 X-MC-Unique: McOlSpgNP1ypz2wh0Do7cg-1 X-Mimecast-MFC-AGG-ID: McOlSpgNP1ypz2wh0Do7cg Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-aa67fcbb549so75590966b.0 for ; Thu, 09 Jan 2025 01:07:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736413631; x=1737018431; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lPmn2NONYx2YB/n7h2bXDX/3a64ALTC7JSKNR4FIJZA=; b=SBW62IYs9u34RUIn2ythqyOWDI9VxelnrB8YFSQJPui5ZXLcx39h50loE02LXm44hy qNdNl2VLK56ARKMPW2BGEJX9Tcf9StWyBVlnTAYD2vGEOBVlY9bQETK6x7RNZe0ik4Zj 57XabOGB6yx3Fq+PhvN4EE3sGavgSIDfbjQG6XTBHM92Iqz3zKAAZkA+VhEDtTzIIPi/ b/AaVNDhFFD/2lbI8M8J4nuSUmob+3acqW/1UiFdRB+tJr6+wH21gl8lN5EMn64JJneW 4/rlPEm36Od5XuC9kZzy8nyUQH8NRPSHv5Ne4RMIwGbHslsrohuU4AeZK4BBe6OiDTg+ Odkw== X-Forwarded-Encrypted: i=1; AJvYcCWkgfY36Y/vHSnZHzqP1mG3NBY3AD4HyiCOGHod4ymbhfQAZ66WvswYJkiwPVuggQpbMCDDrv4db0OyuHU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0StvZ+zYHrVBf6s2U1quMNefpnGYxC3RHEPP3mInwcRqfBiMA sayOuLB7Q8WalFOlPFgfveGsTubl1zMmbtCeHda63zFo5AOy9+Gy34F9p+jxtpopBIrpb6we25i WeAeZr+uOHxTKyP3gauzCvbHSPNChrNNf9ZP3Hke7yAzBOxLlBK5XdE6bXXheog== X-Gm-Gg: ASbGnctYwZL10WWjP2ToZLzsXyKDaudPfVPiiWyJbYkInJFWDbPMcHLVIteo34CCTg/ /i/VttmzOkxv/vLo5AUReXPU5ciiTcalW2OYr86NZpa6BdHc11efsEK7t2uGSlMfNdQ9N17vm/S 3lIK1UQNu9QRiU8u98WvlKoTN37pktuiXZXEcAPLCXNrTwMeJexqbZKWuNTH5KPxcBTMcg2TKEs rGlfnJARJ9MlbnQqJOiEVi+kF1TFgGUKjid6a3mniXwEGbcqw8= X-Received: by 2002:a17:906:d555:b0:aa6:7b34:c1a8 with SMTP id a640c23a62f3a-ab2ab70a5a8mr454046366b.55.1736413631098; Thu, 09 Jan 2025 01:07:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOH7lCleOA3s9UpH750ljDgjJhUOcglbcfKRJdkkDK27qUK57limO+sZa7nGGHTPfbFQQXdg== X-Received: by 2002:a17:906:d555:b0:aa6:7b34:c1a8 with SMTP id a640c23a62f3a-ab2ab70a5a8mr454042766b.55.1736413630614; Thu, 09 Jan 2025 01:07:10 -0800 (PST) Received: from redhat.com ([2a02:14f:175:d62d:93ef:d7e2:e7da:ed72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c95af65dsm49782566b.140.2025.01.09.01.07.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 01:07:09 -0800 (PST) Date: Thu, 9 Jan 2025 04:07:03 -0500 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: netdev@vger.kernel.org, Simon Horman , Stefan Hajnoczi , linux-kernel@vger.kernel.org, Eric Dumazet , Xuan Zhuo , Wongi Lee , "David S. Miller" , Paolo Abeni , Jason Wang , Bobby Eshleman , virtualization@lists.linux.dev, Eugenio =?iso-8859-1?Q?P=E9rez?= , Luigi Leonardi , bpf@vger.kernel.org, Jakub Kicinski , Hyunwoo Kim , Michal Luczaj , kvm@vger.kernel.org Subject: Re: [PATCH net 2/2] vsock/bpf: return early if transport is not assigned Message-ID: <20250109040628-mutt-send-email-mst@kernel.org> References: <20250108180617.154053-1-sgarzare@redhat.com> <20250108180617.154053-3-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250108180617.154053-3-sgarzare@redhat.com> On Wed, Jan 08, 2025 at 07:06:17PM +0100, Stefano Garzarella wrote: > Some of the core functions can only be called if the transport > has been assigned. > > As Michal reported, a socket might have the transport at NULL, > for example after a failed connect(), causing the following trace: > > BUG: kernel NULL pointer dereference, address: 00000000000000a0 > #PF: supervisor read access in kernel mode > #PF: error_code(0x0000) - not-present page > PGD 12faf8067 P4D 12faf8067 PUD 113670067 PMD 0 > Oops: Oops: 0000 [#1] PREEMPT SMP NOPTI > CPU: 15 UID: 0 PID: 1198 Comm: a.out Not tainted 6.13.0-rc2+ > RIP: 0010:vsock_connectible_has_data+0x1f/0x40 > Call Trace: > vsock_bpf_recvmsg+0xca/0x5e0 > sock_recvmsg+0xb9/0xc0 > __sys_recvfrom+0xb3/0x130 > __x64_sys_recvfrom+0x20/0x30 > do_syscall_64+0x93/0x180 > entry_SYSCALL_64_after_hwframe+0x76/0x7e > > So we need to check the `vsk->transport` in vsock_bpf_recvmsg(), > especially for connected sockets (stream/seqpacket) as we already > do in __vsock_connectible_recvmsg(). > > Fixes: 634f1a7110b4 ("vsock: support sockmap") > Reported-by: Michal Luczaj > Closes: https://lore.kernel.org/netdev/5ca20d4c-1017-49c2-9516-f6f75fd331e9@rbox.co/ > Signed-off-by: Stefano Garzarella Acked-by: Michael S. Tsirkin > --- > net/vmw_vsock/vsock_bpf.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/net/vmw_vsock/vsock_bpf.c b/net/vmw_vsock/vsock_bpf.c > index 4aa6e74ec295..f201d9eca1df 100644 > --- a/net/vmw_vsock/vsock_bpf.c > +++ b/net/vmw_vsock/vsock_bpf.c > @@ -77,6 +77,7 @@ static int vsock_bpf_recvmsg(struct sock *sk, struct msghdr *msg, > size_t len, int flags, int *addr_len) > { > struct sk_psock *psock; > + struct vsock_sock *vsk; > int copied; > > psock = sk_psock_get(sk); > @@ -84,6 +85,13 @@ static int vsock_bpf_recvmsg(struct sock *sk, struct msghdr *msg, > return __vsock_recvmsg(sk, msg, len, flags); > > lock_sock(sk); > + vsk = vsock_sk(sk); > + > + if (!vsk->transport) { > + copied = -ENODEV; > + goto out; > + } > + > if (vsock_has_data(sk, psock) && sk_psock_queue_empty(psock)) { > release_sock(sk); > sk_psock_put(sk, psock); > @@ -108,6 +116,7 @@ static int vsock_bpf_recvmsg(struct sock *sk, struct msghdr *msg, > copied = sk_msg_recvmsg(sk, psock, msg, len, flags); > } > > +out: > release_sock(sk); > sk_psock_put(sk, psock); > > -- > 2.47.1