From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF204214A78 for ; Thu, 9 Jan 2025 07:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409082; cv=none; b=AAw8QUuyJDubeurmtA/JZCM4ETBsbBWeLs0sIUVVXqevB7zqjeNTWdlFU/Mm102X9UwAQlIsVCIfOkhvXK+va5t5WnBWsDUdW71+pSS6B3lUPX5Ej9eEQe/BjJERBQmR8kNZ5Fr1ydyUi3OrMfJffWFGdT3VZLwFTSy2q5Bt8e8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736409082; c=relaxed/simple; bh=q5bMp7PJSGnNgxEfef9drZZDGV2cNpjnTsQPTbdE+eE=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=uRdwdDvDkyq1sb9zGKXfelHNEa7OF4pYc8e2k81Yj+HNiNqGsEQrgeEypilc0bbWowYELZQFKdbcZCox4jfi+YZAtdMsmbLGyvBBQKoKkdf1VGK62CM9smtVzaBZVL6duKYyehqLTEYiRWq1e2UBPgs8rNPebf9IK/cKS4O9+Is= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=noB7anb4; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="noB7anb4" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e544c8dae18so1580128276.1 for ; Wed, 08 Jan 2025 23:51:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736409079; x=1737013879; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=BfOiQa/L9OiEEGjP9sXMi3rlBfHgK084BGp4CIjcSjs=; b=noB7anb4kVm8UcHMkZ3ho4ACYz6M01TGB9znVdUPA+SvRVipwC9t00M2gsn5ElCzU0 EPvD/i+8Wf+o0XAF1yhbbLdzW1z+oQrQ/C0fy02QGEHAj3S/XLKc8kMyPOkps6WwGlR1 X7+LIVDEmLzr8TVwD9fWY4uyIj4c/fB74JyMfIe5D0xovVk0Bn3b6b0vjJ+LNIfZ2GRd 15hrVx4+9NmyIYGevb+sq1/ZK1GHxvfWiznp6RPZd0fM8xgmpCB48gw9vTNA0RAUYhtb T4UiOuoECJfcIjJT7ivE/F+JratwZgEAJlRJf1fUIV8CKgBxXe64qWgB+htTeUfCTCVk 0EFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736409079; x=1737013879; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BfOiQa/L9OiEEGjP9sXMi3rlBfHgK084BGp4CIjcSjs=; b=ZgHJV/EqeFLFEav2sEtQc0bdtWnVY4uMQ1Dg+moCWTSo5qxEUd9G2j5Bx2Keb8LURo FpovkrSpQgwns8h/Fcmq1ljNxVV/KVyPHQ07s3jEweYXWllnLmVTBIBLWaeOkV2HY+Ng 2Y+g88BZ461/x09ljcIASesz4c990bb8s7YjAPs4L+2c/eNsdEwFamadNwitsL+GKXIy ERdZukOpiDW51OaiPl1ivTt9FBYVbv8PLHI1uP0r1IKUIioTN43PXDyhDr0r74Wp/TH0 SQTrTm5z1WEvembdad2Tbodp+89XDU0MKG/3P77HnUytISqAeBaXFR5VQdi6boNL5mcv xpHA== X-Forwarded-Encrypted: i=1; AJvYcCX27FXPxAl83PK+8HDUsL+nRtAvl+vjHcjuQ81Fby9H7CUEpqR5eJyV9rpo0ApF5eQfHYt63WPXZeC0LUY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1zVYq7FM2G0YXXV3RjAfEA6hS0Ydl0PB/4BRoMVx5+PQBTGEx aU02JBYggCg8d6C66jWUt6t5Lc2ujRJ4sSgWeNv8GoF6+cEtSAPWLHqKdUQASICOC3kmuTI01HV XMHuxCQ== X-Google-Smtp-Source: AGHT+IHJ+xoP/OiRHl2NwVopvadefTgrOROW0d1nGwF4MhrqP/RTesuhzD45oXRxdaLTiZ5qawBd8auXYm7X X-Received: from irogers.svl.corp.google.com ([2620:15c:2c5:11:f801:f788:c7e5:c181]) (user=irogers job=sendgmr) by 2002:a25:30d5:0:b0:e4a:8f5b:179a with SMTP id 3f1490d57ef6-e54ee276297mr14040276.9.1736409078576; Wed, 08 Jan 2025 23:51:18 -0800 (PST) Date: Wed, 8 Jan 2025 23:50:58 -0800 In-Reply-To: <20250109075108.7651-1-irogers@google.com> Message-Id: <20250109075108.7651-2-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250109075108.7651-1-irogers@google.com> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Subject: [PATCH v1 01/11] perf debug: Avoid stack overflow in recursive error message From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , Yicong Yang , James Clark , Howard Chu , "Dr. David Alan Gilbert" , Levi Yun , Ze Gao , Weilin Wang , Xu Yang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" In debug_file, pr_warning_once is called on error. As that function calls debug_file the function will yield a stack overflow. Switch the location of the call so the recursion is avoided. Signed-off-by: Ian Rogers --- tools/perf/util/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c index 995f6bb05b5f..f9ef7d045c92 100644 --- a/tools/perf/util/debug.c +++ b/tools/perf/util/debug.c @@ -46,8 +46,8 @@ int debug_type_profile; FILE *debug_file(void) { if (!_debug_file) { - pr_warning_once("debug_file not set"); debug_set_file(stderr); + pr_warning_once("debug_file not set"); } return _debug_file; } -- 2.47.1.613.gc27f4b7a9f-goog