From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C3EE201017 for ; Thu, 9 Jan 2025 10:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736419351; cv=none; b=eJAUmD7kfG7xErSimF7LRUXm89YboNHtkoc4gNLxTK/FJltiv7ElUbRbL0yOoU5vCTo9JMZgSN592FA+DfqANDt9KEWLxUgyL/eP9xNgCBkpSZZHOgDgaqe3IZuiO6ErRSpNFPNP+CQu9dx7UYH3HBSnGjyQ8MGQJrY+oNnQITA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736419351; c=relaxed/simple; bh=gvQzzY3rTr5bWSyRypTzpV00xHdL9915lN9GAnqx+GE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FUb2MNfM9efBxASp7dcMep6+PIpxRNfv7y/uQviiwSskm0X6ZmChz980qg2BR4IjTBRu0Y/dd+w+aTgLoyu8B6kaWoX7FHh8gKjaTAzQ4THByPRGSmhdnPzV0RT+I6M0goLgpS737IKNUGqNyfjT1X2aUOPXuCc4LEwJoIS2zTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b3xVfwKG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b3xVfwKG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736419348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HhesIHjEXOQdKGIVXtDnTHMGm10G7kVibhjYANV4VFM=; b=b3xVfwKGZtuD0jUZHIHtJFAytOra0FWgW1xNGHd1eD0XA1Xj18xzSFE/x1N6GPG32UzmwI XWI3szPKHCSHMfMbjy6C9BGtIxNhlUx4emE5gvaYCnylZ4ulcZ/K+tSWOCkZjpeknYqsW5 QKCIbiQrBzMzR5Pi8fjP/Vv2pyfIeAw= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-EbssW_C9NFyUpAyak6Y09w-1; Thu, 09 Jan 2025 05:42:25 -0500 X-MC-Unique: EbssW_C9NFyUpAyak6Y09w-1 X-Mimecast-MFC-AGG-ID: EbssW_C9NFyUpAyak6Y09w Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 464D019560B7; Thu, 9 Jan 2025 10:42:23 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.245]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id E8CB919560AD; Thu, 9 Jan 2025 10:42:13 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 9 Jan 2025 11:41:58 +0100 (CET) Date: Thu, 9 Jan 2025 11:41:47 +0100 From: Oleg Nesterov To: "Dmitry V. Levin" Cc: Eugene Syromyatnikov , Mike Frysinger , Renzo Davoli , Davide Berardi , strace-devel@lists.strace.io, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] ptrace_get_syscall_info: factor out ptrace_get_syscall_info_op Message-ID: <20250109104147.GB26424@redhat.com> References: <20250107230153.GA30560@strace.io> <20250107230446.GD30633@strace.io> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250107230446.GD30633@strace.io> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 01/08, Dmitry V. Levin wrote: > > +ptrace_get_syscall_info_op(struct task_struct *child) > { ... > case SIGTRAP | 0x80: > switch (child->ptrace_message) { > case PTRACE_EVENTMSG_SYSCALL_ENTRY: > - actual_size = ptrace_get_syscall_info_entry(child, regs, > - &info); > - break; > + return PTRACE_SYSCALL_INFO_ENTRY; > case PTRACE_EVENTMSG_SYSCALL_EXIT: > - actual_size = ptrace_get_syscall_info_exit(child, regs, > - &info); > - break; > + return PTRACE_SYSCALL_INFO_EXIT; > } > break; > case SIGTRAP | (PTRACE_EVENT_SECCOMP << 8): > - actual_size = ptrace_get_syscall_info_seccomp(child, regs, > - &info); > + return PTRACE_SYSCALL_INFO_SECCOMP; > + } > + > + return PTRACE_SYSCALL_INFO_NONE; Cosmetic, I won't insist, but I'd suggest to do default: return PTRACE_SYSCALL_INFO_SECCOMP; } to make it more symmetric. Oleg.