From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E9D321506F; Thu, 9 Jan 2025 10:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736419127; cv=none; b=DExJ31UTFaqj5EKmVQSSG8UhbpL6YXxOQzuYqGuKxc8mUALneV29E632tdn05wmgfuVhFS+JhkcYjTdd55qYTtuEp56oQVHpeWuZb8qGNnCA3g+8dV8JjVxV58PK46uwB17K0PGYxbrAE99rRC0UVW4MXJzEJtOMpSWZWr6P4Sk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736419127; c=relaxed/simple; bh=qEA4tmQNWp4shbk/aNzgyYv9DcPAOfiOiGCck4JBJdY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dKTZdd581SbyTh5+xTwmZmcU85weYNVadPXMnYejsLaAwvA1PeRWc/G6p06gi3ke1blr9Ujfjd0AtpdpmGOOS/lAPObysQUbwMA+kHblF13igCcXI3fOvQbpWdkZRz74zc3YHfOEhNB98OiRTC3PfmcuFx681xN1Jvi5s2W+U94= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=YP2hGYZO; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="YP2hGYZO" Received: by mail.gandi.net (Postfix) with ESMTPSA id 3C9DB1BF20C; Thu, 9 Jan 2025 10:38:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1736419117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OKgFPO+Rh1KOhaMMkBZKNFUCZJOyXbfXEXGGNEOMVG8=; b=YP2hGYZO5ngGfo0AvGrIz3Hpm3+2yE+2igYz8io9SdGDFtDRbGanv91vwzQA+AdjCEul8M bUHBSg7W8WBpQ4DkfYYN0SXvmKDHGLOa0hTP+zfQo1sfLFQczD08evufS6y3Zpegq19uhq T2BNJQYyBVRY39PUW2CjPre/GbG1gxCew9jHsLAA4mBikxqziLcgrNgJTMnN+lb135esH+ ZyEv3goWy2dr1l7WWc8F9mHd/bGl6xVTjE1sxJ5WUdAHtxaUxJi+/v7tivv84RX7R7jl7t PRV2sMyB0LIDOF5BkEjjmXdk0LDoxdtsmmjH05i+Jjn/wEl/pvhrwKz8uC0WBA== Date: Thu, 9 Jan 2025 11:38:34 +0100 From: Herve Codina To: Alexander Stein Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Louis Chauvet , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v3 3/3] drm: bridge: ti-sn65dsi83: Add error recovery mechanism Message-ID: <20250109113834.04299a74@bootlin.com> In-Reply-To: <20250108184442.64f38fbc@bootlin.com> References: <20250108101907.410456-1-herve.codina@bootlin.com> <20250108101907.410456-4-herve.codina@bootlin.com> <115787605.nniJfEyVGO@steina-w> <20250108184442.64f38fbc@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Hi Alexander, On Wed, 8 Jan 2025 18:44:42 +0100 Herve Codina wrote: > > > #include > > > #include > > > +#include /* DRM_MODESET_LOCK_ALL_BEGIN() needs drm_drv_uses_atomic_modeset() */ > > > > Shouldn't this include be added to include/drm/drm_modeset_lock.h instead? > > Yes indeed. I will change that in the next iteration. I tried to add '#include ' in include/drm/drm_modeset_lock.h but it breaks the build in several places. First, I cannot add it at the begining of drm_modeset_lock.h. The inclusion path leads to: drm_modeset_lock.h drm/drm_drv.h drm/drm_device.h drm/drm_mode_config.h struct drm_mode_config definition The struct drm_mode_config needs the struct drm_modeset_lock defined. struct drm_modeset_lock is defined in drm_modeset_lock.h. Even if I don't like to add include files in the middle of a header filer, I tried to include drm/drm_drv.h just before the DRM_MODESET_LOCK_ALL_BEGIN() definition in drm_modeset_lock.h. This also breaks the build in several places. For instance: In file included from ./include/drm/drm_modeset_lock.h:162, from ./include/drm/drm_mode_config.h:32, from ./include/drm/drm_device.h:9, from drivers/gpu/drm/drm_dumb_buffers.c:26: ./include/drm/drm_drv.h: In function ‘drm_core_check_all_features’: ./include/drm/drm_drv.h:522:28: error: invalid use of undefined type ‘const struct drm_device’ 522 | u32 supported = dev->driver->driver_features & dev->driver_features; | ^~ I stop here, go back and choose to keep '#include ' in ti-sn65dsi83.c Is that ok for you? Best regards, Hervé