From: Philipp Stanner <phasta@kernel.org>
To: "Luben Tuikov" <ltuikov89@gmail.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Philipp Stanner" <pstanner@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
Philipp Stanner <phasta@kernel.org>
Subject: [PATCH 2/3] drm/sched: Adjust outdated docu for run_job()
Date: Thu, 9 Jan 2025 14:37:11 +0100 [thread overview]
Message-ID: <20250109133710.39404-5-phasta@kernel.org> (raw)
In-Reply-To: <20250109133710.39404-2-phasta@kernel.org>
The documentation for drm_sched_backend_ops.run_job() mentions a certain
function called drm_sched_job_recovery(). This function does not exist.
What's actually meant is drm_sched_resubmit_jobs(), which is by now also
deprecated.
Remove the mention of the deprecated function.
Discourage the behavior of drm_sched_backend_ops.run_job() being called
multiple times for the same job.
Signed-off-by: Philipp Stanner <phasta@kernel.org>
---
include/drm/gpu_scheduler.h | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
index d5cd2a78f27c..c4e65f9f7f22 100644
--- a/include/drm/gpu_scheduler.h
+++ b/include/drm/gpu_scheduler.h
@@ -421,9 +421,12 @@ struct drm_sched_backend_ops {
/**
* @run_job: Called to execute the job once all of the dependencies
- * have been resolved. This may be called multiple times, if
- * timedout_job() has happened and drm_sched_job_recovery() decides to
- * try it again.
+ * have been resolved.
+ *
+ * The deprecated drm_sched_resubmit_jobs() (called from
+ * drm_sched_backend_ops.timedout_job()) can invoke this again with the
+ * same parameters. Doing this is strongly discouraged because it
+ * violates dma_fence rules.
*
* @sched_job: the job to run
*
--
2.47.1
next prev parent reply other threads:[~2025-01-09 13:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 13:37 [PATCH 0/3] drm/sched: Documentation and refcount improvements Philipp Stanner
2025-01-09 13:37 ` [PATCH 1/3] drm/sched: Document run_job() refcount hazard Philipp Stanner
2025-01-09 13:44 ` Tvrtko Ursulin
2025-01-09 13:47 ` Philipp Stanner
2025-01-09 14:01 ` Christian König
2025-01-13 12:07 ` Philipp Stanner
2025-01-09 14:30 ` Danilo Krummrich
2025-01-10 9:14 ` Philipp Stanner
2025-01-09 13:37 ` Philipp Stanner [this message]
2025-01-13 10:20 ` [PATCH 2/3] drm/sched: Adjust outdated docu for run_job() Danilo Krummrich
2025-01-09 13:37 ` [PATCH 3/3] drm/sched: Update timedout_job()'s documentation Philipp Stanner
2025-01-13 11:46 ` Danilo Krummrich
2025-01-20 10:07 ` Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109133710.39404-5-phasta@kernel.org \
--to=phasta@kernel.org \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ltuikov89@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mripard@kernel.org \
--cc=pstanner@redhat.com \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox