public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
	Ben Segall <bsegall@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Will Deacon <will@kernel.org>,
	x86@kernel.org
Subject: Re: [RFC PATCH] preempt: Add a generic function to return the preemption string.
Date: Thu, 9 Jan 2025 16:27:33 +0100	[thread overview]
Message-ID: <20250109152733.VIh584yu@linutronix.de> (raw)
In-Reply-To: <20250109145408.GB5388@noisy.programming.kicks-ass.net>

On 2025-01-09 15:54:08 [+0100], Peter Zijlstra wrote:
> On Thu, Jan 09, 2025 at 03:41:24PM +0100, Sebastian Andrzej Siewior wrote:
> > On 2025-01-09 15:37:01 [+0100], Peter Zijlstra wrote:
> > > Upgrade brain. Also the proposed thing was just plain wrong.
> > 
> > Was it?
> 
> Yes, things like:
> 
> > +             if (preempt_model_voluntary())
> > +                     return "VOLUNTARY+LAZY";
> > +             if (preempt_model_none())
> > +                     return "NONE+LAZY";
> 
> don't exist and make no sense.

point taken.

> > For the !DYNAMIC case everything should be optimized away except
> > for the current case.
> > Let me try your thing to see what is different…
> 
> For the various cases it was supposed to print something like so:
> 
> RT+DYN:	 PREEMPT_{RT,(dyn_mode)}
> RT+LAZY: PREEMPT_{RT,LAZY}
> RT+FULL: PREEMPT_RT
> 
> DYN:       PREEMPT_(dyn_mode)
> FULL:      PREEMPT
> LAZY:      PREEMPT_LAZY
> VOLUNTARY: VOLUNTARY
> NONE:      NONE

Good. I do like it. Let me make a patch.

Sebastian

  reply	other threads:[~2025-01-09 15:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06 11:34 [RFC PATCH] preempt: Add a generic function to return the preemption string Sebastian Andrzej Siewior
2025-01-09  8:55 ` Sebastian Andrzej Siewior
2025-01-09 11:43 ` Peter Zijlstra
2025-01-09 14:37   ` Steven Rostedt
2025-01-09 14:37     ` Peter Zijlstra
2025-01-09 14:41       ` Sebastian Andrzej Siewior
2025-01-09 14:54         ` Peter Zijlstra
2025-01-09 15:27           ` Sebastian Andrzej Siewior [this message]
2025-01-09 17:41             ` Sebastian Andrzej Siewior
2025-01-09 15:53       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250109152733.VIh584yu@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=bsegall@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox