* [PATCH] iio: adc: stm32: Drop unnecessary DT property presence check
@ 2025-01-09 18:23 Rob Herring (Arm)
2025-01-10 11:18 ` Fabrice Gasnier
2025-01-12 15:26 ` Jonathan Cameron
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-01-09 18:23 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Maxime Coquelin,
Alexandre Torgue, Liam Girdwood, Mark Brown
Cc: linux-iio, linux-stm32, linux-arm-kernel, linux-kernel
There's no reason to check for regulator supply property presence before
calling devm_regulator_get_optional() as that will return -ENODEV if
the supply is not present.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
The diff context doesn't show it, but the next line returns on error
other than -ENODEV.
drivers/iio/adc/stm32-adc-core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
index 2201ee9987ae..0914148d1a22 100644
--- a/drivers/iio/adc/stm32-adc-core.c
+++ b/drivers/iio/adc/stm32-adc-core.c
@@ -615,8 +615,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,
}
/* Booster can be used to supply analog switches (optional) */
- if (priv->cfg->has_syscfg & HAS_VBOOSTER &&
- of_property_read_bool(np, "booster-supply")) {
+ if (priv->cfg->has_syscfg & HAS_VBOOSTER) {
priv->booster = devm_regulator_get_optional(dev, "booster");
if (IS_ERR(priv->booster)) {
ret = PTR_ERR(priv->booster);
@@ -628,8 +627,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,
}
/* Vdd can be used to supply analog switches (optional) */
- if (priv->cfg->has_syscfg & HAS_ANASWVDD &&
- of_property_read_bool(np, "vdd-supply")) {
+ if (priv->cfg->has_syscfg & HAS_ANASWVDD) {
priv->vdd = devm_regulator_get_optional(dev, "vdd");
if (IS_ERR(priv->vdd)) {
ret = PTR_ERR(priv->vdd);
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: adc: stm32: Drop unnecessary DT property presence check
2025-01-09 18:23 [PATCH] iio: adc: stm32: Drop unnecessary DT property presence check Rob Herring (Arm)
@ 2025-01-10 11:18 ` Fabrice Gasnier
2025-01-12 15:26 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Fabrice Gasnier @ 2025-01-10 11:18 UTC (permalink / raw)
To: Rob Herring (Arm), Jonathan Cameron, Lars-Peter Clausen,
Maxime Coquelin, Alexandre Torgue, Liam Girdwood, Mark Brown
Cc: linux-iio, linux-stm32, linux-arm-kernel, linux-kernel
On 1/9/25 19:23, Rob Herring (Arm) wrote:
> There's no reason to check for regulator supply property presence before
> calling devm_regulator_get_optional() as that will return -ENODEV if
> the supply is not present.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> The diff context doesn't show it, but the next line returns on error
> other than -ENODEV.
Hi Rob,
Tested on STM32MP157C-EV1,
Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Tested-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Thanks & BR,
Fabrice
>
> drivers/iio/adc/stm32-adc-core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 2201ee9987ae..0914148d1a22 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -615,8 +615,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,
> }
>
> /* Booster can be used to supply analog switches (optional) */
> - if (priv->cfg->has_syscfg & HAS_VBOOSTER &&
> - of_property_read_bool(np, "booster-supply")) {
> + if (priv->cfg->has_syscfg & HAS_VBOOSTER) {
> priv->booster = devm_regulator_get_optional(dev, "booster");
> if (IS_ERR(priv->booster)) {
> ret = PTR_ERR(priv->booster);
> @@ -628,8 +627,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,
> }
>
> /* Vdd can be used to supply analog switches (optional) */
> - if (priv->cfg->has_syscfg & HAS_ANASWVDD &&
> - of_property_read_bool(np, "vdd-supply")) {
> + if (priv->cfg->has_syscfg & HAS_ANASWVDD) {
> priv->vdd = devm_regulator_get_optional(dev, "vdd");
> if (IS_ERR(priv->vdd)) {
> ret = PTR_ERR(priv->vdd);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: adc: stm32: Drop unnecessary DT property presence check
2025-01-09 18:23 [PATCH] iio: adc: stm32: Drop unnecessary DT property presence check Rob Herring (Arm)
2025-01-10 11:18 ` Fabrice Gasnier
@ 2025-01-12 15:26 ` Jonathan Cameron
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2025-01-12 15:26 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Lars-Peter Clausen, Maxime Coquelin, Alexandre Torgue,
Liam Girdwood, Mark Brown, linux-iio, linux-stm32,
linux-arm-kernel, linux-kernel
On Thu, 9 Jan 2025 12:23:25 -0600
"Rob Herring (Arm)" <robh@kernel.org> wrote:
> There's no reason to check for regulator supply property presence before
> calling devm_regulator_get_optional() as that will return -ENODEV if
> the supply is not present.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> The diff context doesn't show it, but the next line returns on error
> other than -ENODEV.
Thanks for that. Saved me opening the file.
Applied to the testing branch of iio.git. Probably next cycle material now.
Jonathan
>
> drivers/iio/adc/stm32-adc-core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 2201ee9987ae..0914148d1a22 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -615,8 +615,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,
> }
>
> /* Booster can be used to supply analog switches (optional) */
> - if (priv->cfg->has_syscfg & HAS_VBOOSTER &&
> - of_property_read_bool(np, "booster-supply")) {
> + if (priv->cfg->has_syscfg & HAS_VBOOSTER) {
> priv->booster = devm_regulator_get_optional(dev, "booster");
> if (IS_ERR(priv->booster)) {
> ret = PTR_ERR(priv->booster);
> @@ -628,8 +627,7 @@ static int stm32_adc_core_switches_probe(struct device *dev,
> }
>
> /* Vdd can be used to supply analog switches (optional) */
> - if (priv->cfg->has_syscfg & HAS_ANASWVDD &&
> - of_property_read_bool(np, "vdd-supply")) {
> + if (priv->cfg->has_syscfg & HAS_ANASWVDD) {
> priv->vdd = devm_regulator_get_optional(dev, "vdd");
> if (IS_ERR(priv->vdd)) {
> ret = PTR_ERR(priv->vdd);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-12 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 18:23 [PATCH] iio: adc: stm32: Drop unnecessary DT property presence check Rob Herring (Arm)
2025-01-10 11:18 ` Fabrice Gasnier
2025-01-12 15:26 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox