From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 495A320ADFC for ; Fri, 10 Jan 2025 10:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736504631; cv=none; b=DIs/nwGQacdvKjsit4N5tZarmZxiCBm8ml6jknCgiBZEzIaEF86FxoFo9LVKi9d6PPFzCJI3zFEpj/cGl1cFdi8pLO/uGSsaXnfQHIGlJwKJudROw9dHoV/2OB0rX++KeDQk7Ze9GNfgmp8VqClpQSD/tfOI/ufkRerWmAJNoVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736504631; c=relaxed/simple; bh=xjzJiHVG1rcoDk2fTADzQ9apBt/E2B/VHNJo4JUJl8g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bjse7eSiSfwIsr0mZz+YAttrOOkqOuwfT68AGv3Yx4fJS4I6baL95OBfNOvF4kh5dfF4CwGr8R775ybA7UymA6Z6npAn70KAxZS9vJEFCoYu5z6yNGe+XX6sojcHVYp0N+x6QwKctol+DxMVsxB/wPE6p4Jp3tCAGXhYQ6Qp8dg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OIgWTgOn; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OIgWTgOn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736504628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jp3bnJiwix2Gu1b46TgPaNYsSc3q3ZVFUH5fpD6tH7A=; b=OIgWTgOncQYJ76cz7i+EwYWMSXfiGGie255eEfaLbw44SQqmfuL0fRdOeBlYTtNxlt9B2l Y/msrtl1oW+l/h6dCiznGspbUNRERmJEYo4pbQuC2avJbe4bkjxWvL2K8mj492Mh84aSTx prR/e7BABVnk2xfoY5viNt/HxNDxNfs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-njOby7XRO-mkbBw7IyLPfA-1; Fri, 10 Jan 2025 05:23:47 -0500 X-MC-Unique: njOby7XRO-mkbBw7IyLPfA-1 X-Mimecast-MFC-AGG-ID: njOby7XRO-mkbBw7IyLPfA Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43623bf2a83so16876735e9.0 for ; Fri, 10 Jan 2025 02:23:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736504626; x=1737109426; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jp3bnJiwix2Gu1b46TgPaNYsSc3q3ZVFUH5fpD6tH7A=; b=S4HHG0gpucWJ3VvRbFRhTfhTr7JRfuhSh9qSWZPB530shVey1GpQTop0kLylhYGOub se08ZHfTgQcNVZAYl/y6OeH2AavcLBmO+qPuVZ/430wD/GMYka8Uy3QCfMDurAvmTBX6 Psdcs6FU894kKuucBpbY/7hwHgtlgLph3Waqinl8YJe7Az4jeY7AtyebPoYQxIXvNH/G t7q+tg42a/YGeCoi0ik76z+Le2qbQRLw+Wqzrve+G0Ae3IN2DJj/sM+0Tsb6WXq5dsVE bsyJCbG5qbyjQ5JbZ99V+7pkyQ8wPXTSp3HwlkjYgbx0qSm7ZbuEKi903elAJHwPcgxa AysA== X-Forwarded-Encrypted: i=1; AJvYcCVS2rg6giMw5yJgJE8X6TPnPT6PlQZC8vXft8zSmPCx/h3iltfHZKZp1Fpi1gi8V0IeFQGaEpbBTmko7V8=@vger.kernel.org X-Gm-Message-State: AOJu0YyY88Iq668RRgW0667+Ctq771AmQkqgXbBMEr6CTP3EFZFSVoiU aqiwG/zIZB5JSWpLylIMtcDWRLMk8E6t7ruJqXohOudVcHswvNPUecfOHbvid2OuYgV1aZ3HBkm qNIkFQls/LWzyb3ygh0IRRdZIuZRNu4L6fOeyMRBt/bzWNY6EE8otffEzEXhrgg== X-Gm-Gg: ASbGncswlyG3yNhsnQX398Y8CMvDtBXSvv9aMfvYVx2vc/Y0SOY6Sqn54u5EvLYAEWJ 25rLMuM2HD2YFfKWU3Ap4apwcXndj3NkYzGG9GcUBbVVkMNTeeH+KIb4Jxh0FDUKJnt4aT8Uoiz akPh3JUglyL6uW4FjUYGjEFBQ/9Yv9uim4b4jK0dCYxOZMEAUlfcA409TJqVZ29ccnk7i1x17PL x5lIqsuCkfP+qB/+pjhaRs9kfF2qjT9swUgBsdFYAOVk5EG+lFk X-Received: by 2002:a05:600c:1e09:b0:436:e751:e445 with SMTP id 5b1f17b1804b1-436e751e61fmr82747635e9.5.1736504625695; Fri, 10 Jan 2025 02:23:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCfvXG8JypksNxAK+IHkKlFtMebcL1LMAzRXVW08Nh57eky+TRviObBgV58/zlzJhK4cMqJA== X-Received: by 2002:a05:600c:1e09:b0:436:e751:e445 with SMTP id 5b1f17b1804b1-436e751e61fmr82747375e9.5.1736504625358; Fri, 10 Jan 2025 02:23:45 -0800 (PST) Received: from redhat.com ([2a06:c701:740d:3500:7f3a:4e66:9c0d:1416]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e03e5fsm47436835e9.18.2025.01.10.02.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 02:23:44 -0800 (PST) Date: Fri, 10 Jan 2025 05:23:40 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Akihiko Odaki , Jonathan Corbet , Willem de Bruijn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Xuan Zhuo , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kselftest@vger.kernel.org, Yuri Benditovich , Andrew Melnychenko , Stephen Hemminger , gur.stavi@huawei.com, devel@daynix.com Subject: Re: [PATCH v2 3/3] tun: Set num_buffers for virtio 1.0 Message-ID: <20250110052246-mutt-send-email-mst@kernel.org> References: <20250109-tun-v2-0-388d7d5a287a@daynix.com> <20250109-tun-v2-3-388d7d5a287a@daynix.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jan 10, 2025 at 11:27:13AM +0800, Jason Wang wrote: > On Thu, Jan 9, 2025 at 2:59 PM Akihiko Odaki wrote: > > > > The specification says the device MUST set num_buffers to 1 if > > VIRTIO_NET_F_MRG_RXBUF has not been negotiated. > > Have we agreed on how to fix the spec or not? > > As I replied in the spec patch, if we just remove this "MUST", it > looks like we are all fine? > > Thanks We should replace MUST with SHOULD but it is not all fine, ignoring SHOULD is a quality of implementation issue.