Re: [RFC PATCH 2/6] dt-bindings: bus: Add qcom,soc-sc7180 SoC

Konrad Dybcio
2025-01-09T14:05:21Z

On 8.01.2025 2:28 AM, Stephen Boyd wrote:
> Document the Qualcomm SC7180 System on a Chip (SoC). This SoC is made up
> of multiple devices that have their own bindings, therefore this binding
> is for a "bus" that is the SoC node.
>
> TODO: Document all child nodes. This is woefully incomplete but at least
> shows what is involved with describing an SoC node in dt schema.

I'm not sure I'm a fan, because...

[...]

> +
> +properties:
> + compatible:
> + items:
> + - const: qcom,soc-sc7180
> + - const: simple-bus
> +
> + '#address-cells':
> + const: 2
> +
> + '#size-cells':
> + const: 2
> +
> + clock-controller@100000:
> + $ref: /schemas/clock/qcom,gcc-sc7180.yaml#
> +
> + watchdog@17c10000:
> + $ref: /schemas/watchdog/qcom-wdt.yaml#
> +
> +required:
> + - compatible
> + - '#address-cells'
> + - '#size-cells'
> + - clock-controller@100000
> + - watchdog@17c10000
> +
> +additionalProperties: false

..this approach will make any dt node addition under /soc require
an additional bindings change, which sounds like absolute madness

I think additionalProperties: true would be sufficient here, like in
Documentation/devicetree/bindings/soc/imx/imx8m-soc.yaml

Konrad