From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC14F213252 for ; Fri, 10 Jan 2025 16:58:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736528314; cv=none; b=H+ciHv8L6JhoN+8p0s/mWwjZkmi/oLlKxArYbCwrbSEgQ5pdTgukiIY9kBMjKv9XOxcKcRqukIgQIg7A6H7HBBKqua2HSPD8ZzA9G6ZPc94O/LrCqkV6QgAFW3KrddLkvi3wOpZ+2M21tU0gIOxJkwKzr/IKxnIO2r47AdSlY74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736528314; c=relaxed/simple; bh=yYdBOFDSpfk3gxfK5sVfgmDIFbpi0HPVXEmmkDTmwZs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AvNMRsemd0b7ANa9AWiadtCTAsvgdikdv2wLfhLZXNavjVdORGenvqPmvSCUVX/gJidKemTm+XTX887rwef/tyQQRQ/j8TezvwNMldG3ao2VHYn/cI+kd4dtwOPf7BFLcbWrU1u6val8DW+TqPdbXJLhxBkVxVsIo0i72hYV1VA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=NkUayUUs; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NkUayUUs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Vri7IoEy9+kGe1nzLrRMhWXBbhzorbp5uPG551q2Krw=; b=NkUayUUsFsa2ZLwHVK465z5RcB HXYNRgskfg3oDXgYJXBSMyZwNB/V6tOlhoseERUEQpQveU4aa62ay+hxcB3IkBprQDR2pFGqTf96V i1rYXK//GQRk5nfR8xIfymCwhpDV1a08MD51MqeyWVlVSoSMyavjQMFjSpv+Umr/l2ZI2VZH9O9PT 7XQlK9ZZpyF9D5N+cP8Yyqkla0eGJ77sgIKgV++pKqOyeu0d+UunpR1y5PwC0oc7UYLfTd8SgYWZV Z+tTDcTKNQsXSj+k/9oYyntIXwt3ylGF41IZUOUjEyTF4reBEUdo3jrm5VnDryL8019Kn7QJNilNb lYlqY1Qg==; Received: from 77-249-17-89.cable.dynamic.v4.ziggo.nl ([77.249.17.89] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tWIL6-0000000E41N-3k24; Fri, 10 Jan 2025 16:58:29 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 75E363005D6; Fri, 10 Jan 2025 17:58:28 +0100 (CET) Date: Fri, 10 Jan 2025 17:58:28 +0100 From: Peter Zijlstra To: Vincent Guittot Cc: mingo@redhat.com, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/fair: Encapsulate set custom slice in a __setparam_fair() function Message-ID: <20250110165828.GD4213@noisy.programming.kicks-ass.net> References: <20250110144656.484601-1-vincent.guittot@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250110144656.484601-1-vincent.guittot@linaro.org> On Fri, Jan 10, 2025 at 03:46:56PM +0100, Vincent Guittot wrote: > Similarly to dl, create a __setparam_fair() function to set parameters > related to fair class and move it in the fair.c file. > > No functional changes expected > > Signed-off-by: Vincent Guittot Thanks! > @@ -5050,6 +5053,26 @@ static inline void util_est_update(struct cfs_rq *cfs_rq, > trace_sched_util_est_se_tp(&p->se); > } > > +void __setparam_fair(struct task_struct *p, const struct sched_attr *attr) > +{ > + struct sched_entity *se = &p->se; > + unsigned int util_est; > + > + p->static_prio = NICE_TO_PRIO(attr->sched_nice); > + if (attr->sched_runtime) { > + se->custom_slice = 1; > + se->slice = clamp_t(u64, attr->sched_runtime, > + NSEC_PER_MSEC/10, /* HZ=1000 * 10 */ > + NSEC_PER_MSEC*100); /* HZ=100 / 10 */ > + } else { > + se->custom_slice = 0; > + se->slice = sysctl_sched_base_slice; > + } > + > + > +} > + > + I've trimmed some of that spurious whitespace. Also, seeing this function, I'm reminded that I used to have that clamp conditional on !CAP_SYS_NICE -- is that something we want to put in again?