From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEDF418C928 for ; Fri, 10 Jan 2025 17:50:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736531457; cv=none; b=Ep4BV3XEWexgDWOX6gpul+p6CRxosfV705QhUU419b2EFJXShfrf+twcYibPRByVBgAYSAZr+QaX3OemVmWkb3n8hXTAYsWYlHNDl7xcJoeiSOFD63IQCAh/8sC+LoRtcxI6tjDGuk2oyijMSanm+jRMECJOcFZ6RMUL5GG3Uak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736531457; c=relaxed/simple; bh=0HMShqd2/r0esqQUBh7NBXLjE3hVE+Ys6VWRlRU0f7Q=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=StDoRyNMkLbXACBgJY0d+OKRs1RzS+ePloR5pjyuiEBib268Q0cdTkX2eDXpHRbaM3dKYH5J8l2VrT6vAGdE3Si7CDGAYZg/BmOqXlIO8vIV9Sqgw9su5ohB28OrCrk+VRkFn0Apni16hfzmrvgJwnH7kp2IV1VMtjC+vvV5ib4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=axzjlSvl; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="axzjlSvl" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2164fad3792so40040655ad.0 for ; Fri, 10 Jan 2025 09:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736531455; x=1737136255; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=h15sO2APBSqbtCowGg5GeEbkHzHgIixqSH50yrPh7oA=; b=axzjlSvlLAyiiARdpWO8GbiNNb+xWxMHfv2k2WnFJgj2NHwooz+bBj5sHsiqBJoONJ Kq9foxb/S1Ksm+Eh8DeNW29Cw5kfsAiBrdYtWv/hvKWp26UXzC4ZS7zUvpPNqis+szcD xsc4lz1hk1uzV0hCnMRIL51WfoFwGIkpOZhE2+v/A2amQPPN2X4TVRpiTkzQDIKeWdML XONFbtgOBihBtrKW2W8IhxlligE70wC8mZsQ0d00jHXkx4RIx7Zg5hU3Ty39GOivnxTa 1dTovResa9rLOKk8HOBLUildd8nc4wzrUMTfADtYPH+SWtMCvsR4mAr+sm7NEtZj1jDC shRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736531455; x=1737136255; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h15sO2APBSqbtCowGg5GeEbkHzHgIixqSH50yrPh7oA=; b=iA5mun5NovKmk8m+G7zXbHixVsrTBY198uJsjNM+SwRvOYcNij1neNrHC0a//H6w9E NjhqKF27Xsp/WFuLEZWdA9kZwoZOXFezUUqDw+1pVDhIC/00SL3VCVPyHunix0j6FYOM qTzHOEXYzErDt9t5ePs/wqzoCvg+nyI9inoF9bMBsQbiKomMfgcMjlE1U4+3zXqtomy4 cYB/I0RevgyxsovoHLtTpc6OoVga2U/pyyfWtJelpPBnlPwQ172g0je8L+20j8zMoS7t zS/bsg0YK1cwKajgQhn2wYITJ4rut9Xnh34LwJEHvMNmkb+bVjRJ66JrhhD4AjzmgHm2 awdQ== X-Gm-Message-State: AOJu0Yzp+GCN6iPYwXmQJBLSLFH7c9Ju3zfxBz3pekCUJq0JJvkBzey5 noPhqHQtrUI0dv9GDS+G3GAT+oikIr6Fb/aREMwCKVrS95duL/lcovx1W+Dsrn6De7yLUbkI0d/ 9TumQo3DI/g== X-Google-Smtp-Source: AGHT+IGVZ5TCw9QmwqEMlqeSzAG2FI2gucCvjnvA5p0uk+35ysAlZbYZ4zANPaNPcGkakytjX8lei3MEW/bL5A== X-Received: from plbje13.prod.google.com ([2002:a17:903:264d:b0:20c:68e5:9884]) (user=cmllamas job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e843:b0:216:2e5e:971d with SMTP id d9443c01a7336-21a83fd9648mr167724585ad.51.1736531455053; Fri, 10 Jan 2025 09:50:55 -0800 (PST) Date: Fri, 10 Jan 2025 17:50:50 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog Message-ID: <20250110175051.2656975-1-cmllamas@google.com> Subject: [PATCH v2] binder: log transaction code on failure From: Carlos Llamas To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Steven Moreland Content-Type: text/plain; charset="UTF-8" When a transaction fails, log the 'tr->code' to help indentify the problematic userspace call path. This additional information will simplify debugging efforts. Cc: Steven Moreland Signed-off-by: Carlos Llamas --- Notes: v2: use %u format specifier per Alice's feedback drivers/android/binder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index ef353ca13c35..45c70644aee5 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -3801,13 +3801,13 @@ static void binder_transaction(struct binder_proc *proc, } binder_debug(BINDER_DEBUG_FAILED_TRANSACTION, - "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n", + "%d:%d transaction %s to %d:%d failed %d/%d/%d, code %u size %lld-%lld line %d\n", proc->pid, thread->pid, reply ? "reply" : (tr->flags & TF_ONE_WAY ? "async" : "call"), target_proc ? target_proc->pid : 0, target_thread ? target_thread->pid : 0, t_debug_id, return_error, return_error_param, - (u64)tr->data_size, (u64)tr->offsets_size, + tr->code, (u64)tr->data_size, (u64)tr->offsets_size, return_error_line); if (target_thread) -- 2.47.1.613.gc27f4b7a9f-goog