RE: [PATCH v3 10/35] x86/bugs: Restructure gds mitigation

Kaplan, David
2025-02-12T15:36:17Z

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Josh Poimboeuf <jpoimboe@kernel.org>
> Sent: Monday, February 10, 2025 5:53 PM
> To: Kaplan, David <David.Kaplan@amd.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>; Borislav Petkov <bp@alien8.de>; Peter
> Zijlstra <peterz@infradead.org>; Pawan Gupta
> <pawan.kumar.gupta@linux.intel.com>; Ingo Molnar <mingo@redhat.com>; Dave
> Hansen <dave.hansen@linux.intel.com>; x86@kernel.org; H . Peter Anvin
> <hpa@zytor.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3 10/35] x86/bugs: Restructure gds mitigation
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Wed, Jan 08, 2025 at 02:24:50PM -0600, David Kaplan wrote:
> > @@ -902,7 +909,7 @@ static void __init gds_select_mitigation(void)
> > } else {
> > gds_mitigation = GDS_MITIGATION_UCODE_NEEDED;
> > }
> > - goto out;
> > + return;
>
> So right above this it clears X86_FEATURE_AVX, should that not be deferred until
> gds_apply_mitigation()?

Yes, will move it.

--David Kaplan