RE: [PATCH v3 05/35] x86/bugs: Restructure taa mitigation

Kaplan, David
2025-02-10T17:19:21Z

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Brendan Jackman <jackmanb@google.com>
> Sent: Monday, February 10, 2025 10:25 AM
> To: Kaplan, David <David.Kaplan@amd.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>; Borislav Petkov <bp@alien8.de>; Peter
> Zijlstra <peterz@infradead.org>; Josh Poimboeuf <jpoimboe@kernel.org>; Pawan
> Gupta <pawan.kumar.gupta@linux.intel.com>; Ingo Molnar <mingo@redhat.com>;
> Dave Hansen <dave.hansen@linux.intel.com>; x86@kernel.org; H . Peter Anvin
> <hpa@zytor.com>; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3 05/35] x86/bugs: Restructure taa mitigation
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Wed, 8 Jan 2025 at 21:27, David Kaplan <david.kaplan@amd.com> wrote:
> > @@ -400,48 +402,71 @@ static void __init taa_select_mitigation(void)
> > return;
> > }
> >
> > - if (cpu_mitigations_off()) {
> > + if (cpu_mitigations_off())
> > taa_mitigation = TAA_MITIGATION_OFF;
> > - return;
> > - }
> >
> > /*
> > * TAA mitigation via VERW is turned off if both
> > * tsx_async_abort=off and mds=off are specified.
> > + *
> > + * MDS mitigation will be checked in taa_update_mitigation().
>
> What we are actually talking about here is the new verw_mitigation_enabled(), right?
> I don't think this block/commentary adds any clarity any more. Maybe just delete it?

Yeah, I think that's fair.

Thanks --David Kaplan