Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

Kees Cook
2025-01-09T17:50:49Z

On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote:
> For the all other case, why should we keep argv/argc and mark them unused
> as well when they aren't being used?

I'm fine either way, but my personal code style instinct is to keep the
"standard" main declaration with argc/argv present. But it's mostly
aesthetic.

And if you think use of kselftest.h isn't universal, then perhaps we can
avoid the macro, but it does seem nicer and more "normal" feeling for
the rest of kernel development.

-Kees

--
Kees Cook