From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFC28207A1D for ; Fri, 10 Jan 2025 09:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736500127; cv=none; b=NPUAAxn/qffD+oP1zIPYcEcsYXQWWcm5rIcEfzPX+XCRCI3BFQs/q06yVJ+wz53Pc0LGJxoJzWbgjSNOw8gPM5ttwnampDusSDuM+E5LufUWKeZf9gZx8PAiGzRBhj/dXPwNYDETdpe0mbSOGExGuOvclKmLbg+TnKiOFmRsMmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736500127; c=relaxed/simple; bh=uDOicdA1/xVX8cwaS5PpyE3UDFJSNkkzP/4LsRdRbxo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rLhKgMJdZWVFn1khWrp2xTS6jRayg8WAKuLB3nOAyk8BeQ1+cWMvw5tYK8Yo2A39iB1WkGhinehmE1g5Q4Xi9JzMDkevVdmeRFLm5sP/DMwlGAf1RWf0N5dnxMqbQDLw3rMUFzr6MTs9c06z9vosuM3KCAmW4lHwfrloS54E8rA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lUpuP2lQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lUpuP2lQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09E4EC4CED6; Fri, 10 Jan 2025 09:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1736500126; bh=uDOicdA1/xVX8cwaS5PpyE3UDFJSNkkzP/4LsRdRbxo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lUpuP2lQbkAQaIrbP18zuB78bbd8fgMBzpcUWn9CTeYb9kQXnYcoqGjTm4X9+VKd5 uaN2EQ3MIbvtMqi0ZacIl84PYwJMkadDqC/zBVtiCAGvFlo2+M4loUwBttw+cvwSeB BiO73W+YhNav+S02TS8gLsau7EwkkSVbnHoN7dT4= Date: Fri, 10 Jan 2025 10:08:43 +0100 From: Greg Kroah-Hartman To: Bartosz Golaszewski Cc: Peter Rosin , linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [RESEND PATCH] mux: constify mux class Message-ID: <2025011034-premium-suitable-8618@gregkh> References: <20241205085605.9501-1-brgl@bgdev.pl> <2024120557-halt-enable-224d@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jan 02, 2025 at 10:21:51AM +0100, Bartosz Golaszewski wrote: > On Thu, Dec 5, 2024 at 10:12 AM Greg Kroah-Hartman > wrote: > > > > On Thu, Dec 05, 2024 at 09:56:05AM +0100, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > All class functions used here take a const pointer to the class > > > structure so we can make the struct itself constant. > > > > > > Signed-off-by: Bartosz Golaszewski > > > --- > > > Greg: Peter picked this up into his branch long before the v6.13 merge > > > window, then never sent it upstream. Could you pick this up this time > > > into your tree? > > > > > > drivers/mux/core.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/mux/core.c b/drivers/mux/core.c > > > index 78c0022697ec7..02be4ba372571 100644 > > > --- a/drivers/mux/core.c > > > +++ b/drivers/mux/core.c > > > @@ -42,7 +42,7 @@ struct mux_state { > > > unsigned int state; > > > }; > > > > > > -static struct class mux_class = { > > > +static const struct class mux_class = { > > > .name = "mux", > > > }; > > > > > > -- > > > 2.45.2 > > > > > > > Sure, will do, thanks. I should sweep the tree for the remaining ones > > as well... > > > > thanks, > > > > greg k-h > > Hi! Gentle ping because I'm not sure if this got lost or you're still > getting to it in your queue. Sorry for the delay, will get this now. greg k-h